zeitgeist
zeitgeist copied to clipboard
Migrate neo-swaps pools to bounded storage
What does it do?
Migrates neo-swaps pools from BTreeMap
to BoundedBTreeMap
to avoid potentially faulty manual MaxEncodedLen
implementations. Fixes #1214.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References
Codecov Report
Attention: Patch coverage is 94.20290%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 91.89%. Comparing base (
d3017c1
) to head (fee8921
).
Files | Patch % | Lines |
---|---|---|
zrml/neo-swaps/src/lib.rs | 76.19% | 5 Missing :warning: |
zrml/neo-swaps/src/migration.rs | 97.27% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 91.82% 91.89% +0.07%
==========================================
Files 190 191 +1
Lines 34682 34793 +111
==========================================
+ Hits 31847 31974 +127
+ Misses 2835 2819 -16
Flag | Coverage Δ | |
---|---|---|
tests | 91.89% <94.20%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request is now in conflicts. Could you fix it @maltekliemann? 🙏