libCZI icon indicating copy to clipboard operation
libCZI copied to clipboard

Add CMake install commands

Open thomasgt opened this issue 6 years ago • 3 comments

This pull request adds CMake install() directives for the libCZI, libCZIStatic, and CZIcmd targets. This allows you to run make install on Unix systems or generates an INSTALL project for Visual Studio. It will put the libraries and public headers wherever CMAKE_INSTALL_PREFIX points.

I had to split out the libCZI sources to access the public headers so they can be installed with the library. It might be desirable to add another directory level for the installed includes to keep them isolated.

thomasgt avatar Sep 05 '18 14:09 thomasgt

Dear @ptahmose, would it be possible to review or comment on this PR? It looks good to me, and an install target would be beneficial to using libCZI in continuous integration environments.

Is the PR acceptable or do you require changes?

emmenlau avatar Jun 10 '19 10:06 emmenlau

A few unrelated bug fixes made their way onto this branch. I should probably split them off onto a separate branch before anything gets merged.

thomasgt avatar Jun 10 '19 13:06 thomasgt

I've seen them, but they seem pretty harmless. But of course it can only help if you can clean up the pull request, so two thumbs up from my side.

emmenlau avatar Jun 10 '19 19:06 emmenlau

Closing. Repo will be archived in favor of https://github.com/ZEISS/libczi.

zeissmicroscopy avatar Sep 30 '22 17:09 zeissmicroscopy