Chris Hofstaedtler

Results 269 comments of Chris Hofstaedtler

> Perhaps we can mention GPLv2 explicitly then? If you do, point to NOTICE, as its not 'plain GPLv2'?

> @zeha okay, I got curious; I built https://source.mnt.re/zeha/pocket-reform/-/tree/zeha-sysctl-usbids and that seems to reboot to BOOTSEL just fine -- but that doesn't have the GetFirmwareVersion call. Sorry, for "reasons" I'm...

> > I'm confused about bcdREV. Do you mean bcdDevice? > > Yup, sorry, too many acronyms. Using the bcdDevice GUID for the firmware "stream" is quite sensible. Thanks for...

> @zeha how did you get on? Any complain if I rename the plugin in your branch to `rp2-pico`? @hughsie sorry, was swamped with other work. There's still some discussion...

> > but i think generally for rp2040 (and probably rp2350) devices the plugin should be fine > > Bleh, that makes choosing a plugin name much harder :) Is...

I've pushed this branch to be: * code from https://github.com/fwupd/fwupd/pull/7936 * new plugin rp-pico Three things open in particular: * testing that this really works * fix the TODO to...

> > ``` > > testing that this really works > > ``` > > Did you get the BOS descriptor addition working? Currently on it, but looking good: ```...

> > > fourth item: ignore error from reset request if not using a fixed usb stack on the device > > > > > > Does it bubble up...

@hughsie okay, this branch (incl your commit e4130bda95e1b585d6a8981058264afc5e145947) seems to work perfectly. Edit: I forgot about the bcd version problem. This manifests as a lot of spam :) : ```...

> Did you set the version format in the descriptor before you set the version? Also, if you can rebase squashing my fixup I think we can just merge this...