Dealga McArdle

Results 512 comments of Dealga McArdle

this could be worse :) ```python _highspeed_NodeSocket_Origins = {} def get_prop_name(self): """ Intended to return name of property related with socket owned by its node Name can be replaced by...

yes! suitable. also is there a genuine need to check `node` here? ```python if node and getattr(node, 'does_support_draft_mode', False) and getattr(node.id_data, 'sv_draft', False): prop_name_draft = node.draft_properties_mapping.get(self.prop_name, None) if prop_name_draft: return...

maybe i'm missing some logic here but.. ```python def get_prop_name(self): """ Intended to return name of property related with socket owned by its node Name can be replaced by twin...

unless we are testing the result of `isinstance(self.get_prop_name(), list)` somewhere..

> Potentially it requires a lot of little fixes in code of nodes. akward : /

If it's really worth avoiding `self.node` maybe gradually convert nodes? and make `node` an optional kw of sv_get ? ``` def sv_get(self, default=sentinel, deepcopy=True, implicit_conversions=None, node=None) ... ``` and same...

ok. i think the vast majority of nodes can be updated with a relatively simple search/replace, the remaining 20/30 nodes we can do by hand.

i suspect sockets could have a `socket_dict` ? inside which we could store a link when made and remove the link when disconnected? if so it would also be able...

if `self.node` is expensive, why is that? it is Blender's api.. https://docs.blender.org/api/current/bpy.types.NodeSocket.html#bpy.types.NodeSocket.node maybe there is some speedup to be gained in the node api ?

small rewrite (altho not for readability) ```python def make_sphere_verts_combined_np(U, V, Radius): i_range = np.arange(1, V-1) j_range = np.tile(np.arange(U), V-2) theta_j_range = np.radians(360 / U) * j_range.T phi_i_range = np.radians(180 /...