csnappy
csnappy copied to clipboard
zeevt
Parallel tests fail
The latest commit 6c10c305e8dde193546e6b33cf8a785d5dc123e2 added check_unaligned_uint64 test which calls "make clean". As a result if tests are performed in parallel (e.g. "make -j4 test"), they fail because the clean target deletes files expected by concurrent jobs.
The tests also destroy the library file built with "make". So people doing "make && make test && make install" end up installing testing library (built with "EXTRA_TEST_CFLAGS="-O3 -march=native" make check_unaligned_uint64_extra_cflags").
I recommend removing all the EXTRA_TEST_CFLAGS="-O0" overrides so that people test a install a code they indeed wanted to build.
I see there is "make clean" at the end of check_unaligned_uint64_extra_cflags target. So the previous comment is not true.