Zeel Darji

Results 43 comments of Zeel Darji

@vatsa287 Can you please give your feedback on the PR

Hello @vatsa287 , The `PeerId` is created when `node_id` is converted into **byte vector** which is later passed in `generate_peer_id` function which encodes it in **UTF8** and decodes it in...

@vatsa287 The test has passed but the build action has failed due to some other reason

@vatsa287 , I would like to work on some more issues , do you have any specific issues for me ?

Hello @amarts I was going through the `network-membership` pallet , It has a defined storage for `MemberShipBlacklist` , is it for the same purpose as mentioned in the issue above...

> Please add something in description saying that this is a internal change and all the user related APIs should work without any issues in the testcases section. Done @ThisIsMani...

> Hey @zeel991, can you check the original template and change you PR description into that template. Are these changes appropriate ?

Hello @ThisIsMani ,would you please consider adding the `hactoberfest` tag to the PR

Hey @ThisIsMani , since this PR is approved, when can it be merged ?

> Hey @zeel991, can you resolve the conflicts. Done ! 👍🏻