broker icon indicating copy to clipboard operation
broker copied to clipboard

Broker include broken

Open J-Gras opened this issue 10 months ago • 3 comments

I have some external project that uses Zeek's FindBroker.cmake to link against broker. With the current zeek master the build stopped working. Configure exists with the following error:

CMake Error at /usr/local/zeek/share/zeek/cmake/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Broker (missing: BROKER_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/zeek/share/zeek/cmake/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  my-proj/cmake/FindBroker.cmake:74 (find_package_handle_standard_args)
  my-proj/CMakeLists.txt:14 (find_package)

Comparing with installs of previous Zeek versions, I noticed config.hh missing in include/broker. Maybe it's related to https://github.com/zeek/broker/commit/3c64a311d802348f020eaf3eda3042d4d9cb4b1d.

J-Gras avatar Apr 01 '24 14:04 J-Gras

@Neverlord any update on this? It continues to bite us :-(

vpax avatar May 06 '24 15:05 vpax

Thank you for the ping! Really sorry for the wait here. This fell off my radar because I got knocked out for a couple weeks by a really bad flu last month.

@J-Gras I have patch ready in issue/gh-399. Mind double-checking before I open up a PR?

Neverlord avatar May 06 '24 15:05 Neverlord

I just did a Zeek install with the Broker submodule on issue/gh-399 and I can confirm that it installs config.hh again. I don't have a quick way to verify FindBroker but since it too depends on config.hh I'm optimistic this'll fix it.

ckreibich avatar May 06 '24 17:05 ckreibich

For the record, I can confirm that the patch fixes the issue for the external project using FindBroker.cmake. Thanks!

J-Gras avatar May 07 '24 08:05 J-Gras