Jeff Wendling

Results 62 comments of Jeff Wendling

Ah, yeah. Since gRPC internally maintains a connection pool as well as does rpc multiplexing, I imagine it can do something other than closing the connection on a context cancel....

Hmm. If the rpc is finished, cancel should not cause the connection to close. There should be a bunch of test cases around that behavior. Am I misunderstanding what you...

Cool. The rpcpool checks Closed on the way out because that's the latest possible time, so it has the smallest chance of being stale. I think this is something many...

Haha, yeah the API of rpcpool being weird is why it's not linked. The API is tailored to some pretty specific and weird requirements that Storj has. Thanks for the...

I pushed up a change to our gerrit code review instance that includes a connection pool based on the design in the storj rpcpool: https://review.dev.storj.io/c/storj/drpc/+/8599 I think it's easier to...

That usage does seem correct. I'm writing some tests to see if I can reproduce.

So here's a test I've been running and have been unable to reproduce the error: ```go func TestCancelRepeatedPooled(t *testing.T) { tctx := drpctest.NewTracker(t) defer tctx.Close() server := impl{ Method2Fn: func(stream...

The test isn't committed, but you can put it in `internal/integration/common_test.go` and run the tests from inside that folder.

Whoops! I forgot that I included other changes to some supporting files. I have pushed a commit with the test up. Also, it now fails for me locally sometimes. I...

I believe we keep logs of these checks somewhere. If you could provide your node ID I can do my best to look up what happened for these checks. While...