zedongh

> For interface and implementation seperation, doc comment on interface not concrete implementation should be a right choice. But i find swag not parse, how it works? > > Here...

> values `interface` method defined input argement and return values much better. Buf for gin web framework handler, the return value always be void, response always be put into `*gin.Context`,...

> declaration > @zedongh did you tried? > > ```go > // Ping godoc > // @Summary Server health probe > // @Description server running health check > // @Tags...

Any new progress about this proposal now?

Is there any idea about this feature implementation?

#5307

> please make following changes: > > * use `strings.Builder` for better performance; see [here](https://medium.com/@felipedutratine/string-concatenation-in-golang-since-1-10-bytes-buffer-vs-strings-builder-2b3081848c45) > * change commit msg to `perf: use strings.Builder in GoString` > * rename `writeIntoBuffer`...

> also ensure `gofmt` and `govet` is done on file; done

> ok，my pleasure here #111 And, for truncate commit, hope jv support -flag truncate, print few error and stop, rather than print all of error.

Yeah, i meet this problem recently ... ```text fatal error: concurrent map read and map write /go/src/gitlab.momenta.works/hdmap-workflow/cadence-system-worker/internal/workflowimpl/workflow_interpreter.go:429 +0x25d gitlab.momenta.works/hdmap-workflow/cadence-system-worker/internal/workflowimpl.(*ExecutionVisitor).visitActivityInvocation.func1() go.uber.org/cadence/internal.(*workflowEnvironmentImpl).UpsertSearchAttributes(0xc0165d2120, 0xc00d6db8f0?) /go/pkg/mod/go.uber.org/[email protected]/internal/workflow.go:1347 +0x90 go.uber.org/cadence/internal.UpsertSearchAttributes({0x1190758, 0xc000bc61b0}, 0xfef115?) /go/pkg/mod/go.uber.org/[email protected]/internal/internal_decision_state_machine.go:951 +0x89 go.uber.org/cadence/internal.(*decisionsHelper).addDecision(0xc007b885d0, {0x1199208,...