zed icon indicating copy to clipboard operation
zed copied to clipboard

can we have this app in flathub and snapstore

Open olumolu opened this issue 1 year ago • 9 comments

Check for existing issues

  • [X] Completed

Describe the feature

We use redhat on our office and personally i have mac and a fedora system so it is easy for me to switch to this from vscode which i was using and having it in flathub or snap make it easy. Having this makes my transaction easy as i can use it on my mac but not on my other systems.

Edit As of now a hugh no of people are switching to a immune variant or immutable distros like silverblue steam os opensuse aeon or ublue projects and now it is that ubuntu is also switching to a snap based immutable variant hence it is evident that we should have snap and flatpak. Make sure that we have this in flathub. So users Dont need to scrape internet.

If applicable, add mockups / screenshots to help present your vision of the feature

Verified apps in snapstore and flathub

olumolu avatar Mar 28 '24 16:03 olumolu

We are now available on Flathub :)

mikayla-maki avatar Jul 28 '24 19:07 mikayla-maki

We are now available on Flathub :)

It is not verified can you make it verified.

olumolu avatar Jul 29 '24 04:07 olumolu

We are now available on Flathub :)

It is not verified can you make it verified.

Just use the flatpak, stop asking

buonhobo avatar Jul 29 '24 05:07 buonhobo

We are now available on Flathub :)

It is not verified can you make it verified.

Just use the flatpak, stop asking

Ok but still having a verified badge make it better.

olumolu avatar Jul 29 '24 06:07 olumolu

@mikayla-maki Verification is pretty easy, https://docs.flathub.org/docs/for-app-authors/verification It'd be really appreciated :P (Once it's officially supported)

Beryesa avatar Aug 03 '24 06:08 Beryesa

Since it is already available on flathub, I think this issue is ready to be closed.

If the verification of the bundle is a problem, a new issue can be opened.

sofaspawn avatar Dec 25 '24 18:12 sofaspawn

I've pushed a branch which builds a snap package based off of zed release tarballs - https://github.com/zed-industries/zed/tree/snap-package, so building the snap package is quite quick. However, it's not quite polished.

Unexpected logs

I get all of these logs when loading the zed repo into zed run via snap. Curiously these seem to be benign - things seem to work fine. I will use the snap version of zed and see if I encounter any actual breakage.

[2025-02-03T00:34:14-07:00 ERROR home] No such file or directory (os error 2)
[2025-02-03T00:34:14-07:00 ERROR worktree] failed to canonicalize root path: No such file or directory (os error 2)
[2025-02-03T00:34:15-07:00 ERROR languages::rust] failed to run rust-analyzer after detecting it in PATH: binary: "/home/mgsloan/.cargo/bin/rust-analyzer": No such file or directory (os error 2)
[2025-02-03T00:34:16-07:00 ERROR languages::rust] failed to run rust-analyzer after detecting it in PATH: binary: "/home/mgsloan/.cargo/bin/rust-analyzer": Not a directory (os error 20)
[2025-02-03T00:34:16-07:00 ERROR languages::rust] failed to run rust-analyzer after detecting it in PATH: binary: "/home/mgsloan/.cargo/bin/rust-analyzer": Not a directory (os error 20)
[2025-02-03T00:34:16-07:00 ERROR project::lsp_store] Failed to start language server "rust-analyzer": failed to spawn command. path: "/home/mgsloan/.local/share/zed/languages/rust-analyzer/rust-analyzer-2025-02-03", working directory: "/home/mgsloan/oss/livekit-rust-sdks/livekit-api/src", args: []
[2025-02-03T00:34:16-07:00 ERROR project::lsp_store] server stderr: ""
[2025-02-03T00:34:16-07:00 ERROR languages::rust] failed to run rust-analyzer after detecting it in PATH: binary: "/home/mgsloan/.cargo/bin/rust-analyzer": Not a directory (os error 20)

Snapcraft lint

  • library: libvulkan.so.1: unused library 'usr/lib/x86_64-linux-gnu/libvulkan.so.1.3.275'. (https://snapcraft.io/docs/linters-library)

However if I omit libvulkan1 from stage-packages running the cli via zed just hangs with no output. Running zed --help works. Setting the snap's command to libexec/zed-editor runs and complains that vulcan is not found.

mgsloan avatar Feb 03 '25 08:02 mgsloan

@mgsloan rust-analyzer has an annoying corner case where rustup puts a broken shim into the path; which we work-around (but noisily log about): https://github.com/zed-industries/zed/pull/17951

Is it capable of running other language servers from $PATH? (I would have thought so, it looks like you're using the "no sandbox" mode).

ConradIrwin avatar Feb 04 '25 01:02 ConradIrwin

I'm going to share what I found for anyone else interested in the status of verification.

First, the Zed team was not responsible for the pull request that added Zed to flathub: https://github.com/flathub/flathub/pull/5253 ; although, they were aware and were potentially granted write access to the resulting repository. However, I see no participation by any Zed team members on the repository.

So while this might be semi-endorsed by the Zed team, it is apparently not the result of effort by them.

You can however verify what source is currently being used by looking at: https://github.com/flathub/dev.zed.Zed/blob/master/dev.zed.Zed.yaml

Currently: url: https://github.com/zed-industries/zed/releases/download/v0.187.9/zed-linux-x86_64.tar.gz

The most recent comment I could find by a team member regarding verification was by @maxdeviant:

"When we’re ready for Flathub verification, we’ll just add a route to the zed.dev site that returns the verification code."

The other most relevant comment I could find was by @ConradIrwin:

  • We are not going to make changes to interact with bespoke sandboxes for the foreseeable future – our first priority has to be a non-sandboxed linux install that works well. If you would like to run zed in a sandbox, you are welcome to do so, but we're unlikely to prioritize issues if stuff doesn't work because of that.

So my guess would be that until Zed is more stabilized (i.e. reaches v1.0.0), and the sandbox issues are addressed as much as possible, we probably won't be seeing verification.

derek-v-s avatar May 28 '25 01:05 derek-v-s