zed
zed copied to clipboard
`cargo clippy` in Zed repo fail to compile
Check for existing issues
- [X] Completed
Describe the bug / provide steps to reproduce it
I ran cargo clippy
at the root of the Zed project and it failed to compile. Compiling with cargo build
seemed to work, though I didn't actually try running the compiled binary. I noticed that CI uses script/clippy
, which passes, so this may be moot.
Here is the output:
❯ cargo --version
cargo 1.76.0 (c84b36747 2024-01-18)
❯ cargo clippy
Checking ahash v0.8.8
Checking either v1.9.0
Checking tracing-core v0.1.31
Checking unicode-normalization v0.1.22
Compiling digest v0.10.7
Checking futures-sink v0.3.30
Compiling indexmap v2.0.0
Checking futures-channel v0.3.30
Checking itertools v0.10.5
Compiling sha2 v0.10.7
Checking hashbrown v0.14.0
Checking hashbrown v0.13.2
Checking futures-util v0.3.30
Checking tracing v0.1.37
Checking idna v0.4.0
Compiling rust-embed-utils v8.2.0
Checking rand v0.8.5
Compiling which v4.4.2
Checking regalloc2 v0.9.3
Compiling rust-embed-impl v8.2.0
Checking url v2.4.1
Checking num-integer v0.1.45
Checking gimli v0.28.0
Checking object v0.32.1
Checking serde_json v1.0.107
Checking wasmparser v0.121.2
Checking rayon v1.8.0
Checking tracing-futures v0.2.5
Checking isahc v1.7.2
Checking collections v0.1.0 (/Users/brian/code/zed/crates/collections)
Checking futures-executor v0.3.28
Checking futures v0.3.28
Compiling bindgen v0.65.1
Checking num-iter v0.1.43
Checking postage v0.5.0
Checking sum_tree v0.1.0 (/Users/brian/code/zed/crates/sum_tree)
Checking time v0.3.28
Checking jpeg-decoder v0.1.22
Checking cranelift-codegen v0.105.1
Checking addr2line v0.21.0
Checking uuid v1.4.1
Compiling cbindgen v0.26.0
Checking tiff v0.6.1
Checking backtrace v0.3.69
Checking num-rational v0.3.2
Compiling derive_refineable v0.1.0 (/Users/brian/code/zed/crates/refineable/derive_refineable)
Checking wasmtime-types v18.0.1
Checking schemars v0.8.15
Checking image v0.23.14
Checking wasmtime-environ v18.0.1
Checking rust-embed v8.2.0
Checking refineable v0.1.0 (/Users/brian/code/zed/crates/refineable)
Checking resvg v0.14.1
Checking itertools v0.11.0
Checking util v0.1.0 (/Users/brian/code/zed/crates/util)
Compiling gpui_macros v0.1.0 (/Users/brian/code/zed/crates/gpui_macros)
Checking wasmtime-runtime v18.0.1
Checking bromberg_sl2 v0.6.0 (https://github.com/zed-industries/bromberg_sl2?rev=950bc5482c216c395049ae33ae4501e08975f17f#950bc548)
Checking clock v0.1.0 (/Users/brian/code/zed/crates/clock)
Checking git2 v0.15.0
Checking fsevent v2.0.2 (/Users/brian/code/zed/crates/fsevent)
Checking serde_json_lenient v0.1.7
error: &-masking with zero
--> crates/fsevent/src/fsevent.rs:19:1
|
19 | / bitflags! {
20 | | #[repr(C)]
21 | | pub struct StreamFlags: u32 {
22 | | const NONE = 0x00000000;
... |
46 | | }
47 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask
= note: `#[deny(clippy::bad_bit_mask)]` on by default
= note: this error originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `fsevent` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Environment
Zed: v0.124.8 (Zed) OS: macOS 14.2.1 Memory: 24 GiB Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log
file to this issue.
If you only need the most recent lines, you can run the zed: open log
command palette action to see the last 1000.
No response