zed icon indicating copy to clipboard operation
zed copied to clipboard

Published 20 hours ago • verified publisher icon zed-industries

Add a fish-specific fix for #8633

Open WeetHet opened this issue 11 months ago • 4 comments

Release Notes:

  • Fixed detection of direnv not working in fish when an LSP adapter (gopls, for example) tries to detect user-installed binaries. (#8633)

WeetHet avatar Mar 01 '24 11:03 WeetHet

@mrnugget could you review this?

WeetHet avatar Mar 01 '24 11:03 WeetHet

Great! I simplified code a bit and moved the comment around (and mentioned fish). Will merge once CI is green — you did test that this makes it work, right?

mrnugget avatar Mar 01 '24 12:03 mrnugget

Great! I simplified code a bit and moved the comment around (and mentioned fish). Will merge once CI is green — you did test that this makes it work, right?

Yes, it works for me. I'd appreciate you double checking it though

WeetHet avatar Mar 01 '24 13:03 WeetHet

@mrnugget could you check if it works for you and if it does, merge this pr?

WeetHet avatar Mar 01 '24 17:03 WeetHet