zed icon indicating copy to clipboard operation
zed copied to clipboard

linux: wayland: implement cursor style handling

Open joelselvaraj opened this issue 1 year ago • 9 comments

Release Notes:

  • Implemented cursor style changing in wayland

zed_cursor_wayland.webm

joelselvaraj avatar Feb 29 '24 19:02 joelselvaraj

We require contributors to sign our Contributor License Agreement, and we don't have @joelselvaraj on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 29 '24 19:02 cla-bot[bot]

We require contributors to sign our Contributor License Agreement, and we don't have @joelselvaraj on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 29 '24 19:02 cla-bot[bot]

@cla-bot check

joelselvaraj avatar Feb 29 '24 19:02 joelselvaraj

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 29 '24 19:02 cla-bot[bot]

Still needs animated cursor support, but could be implemented in a later PR.

phisch avatar Feb 29 '24 20:02 phisch

Still needs animated cursor support, but could be implemented in a later PR.

Yes.

joelselvaraj avatar Feb 29 '24 21:02 joelselvaraj

Just for the record, wayland has the cursor-shape-v1 protocol. It is currently implemented in kwin and wlroots (including sway). Mutter has an open issue for it: https://gitlab.gnome.org/GNOME/mutter/-/issues/3276

Once this is implemented in the major compositors, this code can be simplified by a lot.

phisch avatar Feb 29 '24 22:02 phisch

Just for the record, wayland has the cursor-shape-v1 protocol. It is currently implemented in kwin and wlroots (including sway). Mutter has an open issue for it: https://gitlab.gnome.org/GNOME/mutter/-/issues/3276

Once this is implemented in the major compositors, this code can be simplified by a lot.

Yes. I had a look at it earlier. Hope it gets implemented in other compositors too. Handling cursors in wayland seems unnecessarily complicated right now.

joelselvaraj avatar Mar 01 '24 00:03 joelselvaraj

This will need adjusting if the #8365 is merged first (or vice versa)

flukejones avatar Mar 01 '24 08:03 flukejones