Clippy doesn't work

[nesrve]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

Hello, I'm trying to get Zed to run checks with clippy, but it seems to not work. This is my settings:

{
  "language_overrides": {
    "Rust": {
      "inlay_hints": {
        "enabled": true
      }
    }
  },
  "lsp": {
    "rust-analyzer": {
      "initialization_options": {
        "checkOnSave": "clippy"
      }
    }
  }
}

Environment

Zed: v0.125.0 (Zed Preview) OS: macOS 14.3.1 Memory: 8 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

2024-02-28T22:06:59+01:00 [INFO] ========== starting zed ==========
2024-02-28T22:06:59+01:00 [INFO] Opening main db
2024-02-28T22:06:59+01:00 [INFO] set environment variables from shell:/bin/zsh, path:/Library/Frameworks/Python.framework/Versions/3.12/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Users/evrsen/.cargo/bin:/Users/evrsen/Library/Application Support/JetBrains/Toolbox/scripts:/Users/evrsen/.local/bin
2024-02-28T22:07:00+01:00 [ERROR] crates/zed/src/zed.rs:569: EOF while parsing a value at line 1 column 0
2024-02-28T22:07:00+01:00 [INFO] Opening main db
2024-02-28T22:07:00+01:00 [INFO] build git repository ".git"
2024-02-28T22:07:00+01:00 [INFO] Opening main db
2024-02-28T22:07:00+01:00 [INFO] set status on client 0: Authenticating
2024-02-28T22:07:00+01:00 [INFO] Opening main db
2024-02-28T22:07:00+01:00 [INFO] set status on client 84057: Connecting
2024-02-28T22:07:00+01:00 [ERROR] crates/workspace/src/persistence/model.rs:257: No worktree for path: "/Users/evrsen/.config/zed/settings.json"
2024-02-28T22:07:00+01:00 [INFO] starting language server "rust-analyzer", path: "/Users/evrsen/Developer/RustroverProjects/sys-time-format", id: 1
2024-02-28T22:07:00+01:00 [INFO] querying GitHub for latest version of language server "rust-analyzer"
2024-02-28T22:07:00+01:00 [INFO] Node runtime install_if_needed
2024-02-28T22:07:00+01:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc
2024-02-28T22:07:00+01:00 [INFO] starting language server. binary path: "/Users/evrsen/Library/Application Support/Zed/node/node-v18.15.0-darwin-arm64/bin/node", working directory: "/", args: ["/Users/evrsen/Library/Application Support/Zed/copilot/copilot-v0.5.0/dist/agent.js", "--stdio"]
2024-02-28T22:07:01+01:00 [INFO] checking if Zed already installed or fetching version for language server "rust-analyzer"
2024-02-28T22:07:01+01:00 [INFO] starting language server. binary path: "/Users/evrsen/Library/Application Support/Zed/languages/rust-analyzer/rust-analyzer-2024-02-26", working directory: "/Users/evrsen/Developer/RustroverProjects/sys-time-format", args: []
2024-02-28T22:07:01+01:00 [INFO] Language server with id 1 sent unhandled notification experimental/serverStatus:
{
  "health": "ok",
  "quiescent": false,
  "message": null
}
2024-02-28T22:07:01+01:00 [INFO] Language server with id 0 sent unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2024-02-28T21:07:01.389Z] Agent service starting",
  "metadataStr": "[DEBUG] [agent] [2024-02-28T21:07:01.389Z]",
  "extra": [
    "Agent service starting"
  ]
}
2024-02-28T22:07:01+01:00 [INFO] Language server with id 0 sent unhandled notification client/registerCapability:
{
  "registrations": [
    {
      "id": "b480ccd6-0c43-46f3-b760-610762721beb",
      "method": "workspace/didChangeWorkspaceFolders",
      "registerOptions": {}
    }
  ]
}
2024-02-28T22:07:01+01:00 [INFO] Language server with id 0 sent unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2024-02-28T21:07:01.404Z] Telemetry initialized",
  "metadataStr": "[DEBUG] [agent] [2024-02-28T21:07:01.404Z]",
  "extra": [
    "Telemetry initialized"
  ]
}
2024-02-28T22:07:01+01:00 [INFO] add connection to peer
2024-02-28T22:07:01+01:00 [INFO] waiting for server hello
2024-02-28T22:07:01+01:00 [INFO] got server hello
2024-02-28T22:07:01+01:00 [INFO] set status to connected (connection id: ConnectionId { owner_id: 0, id: 0 }, peer id: PeerId { owner_id: 346, id: 1214127 })
2024-02-28T22:07:01+01:00 [INFO] set status on client 84057: Connected { peer_id: PeerId { owner_id: 346, id: 1214127 }, connection_id: ConnectionId { owner_id: 0, id: 0 } }
2024-02-28T22:07:03+01:00 [INFO] Language server with id 1 sent unhandled notification experimental/serverStatus:
{
  "health": "ok",
  "quiescent": true,
  "message": null
}
2024-02-28T22:07:34+01:00 [INFO] open paths ["/Users/evrsen/.config/zed/settings.json"]
2024-02-28T22:07:34+01:00 [INFO] Initializing default prettier with plugins {}
2024-02-28T22:07:34+01:00 [INFO] starting language server "json-language-server", path: "/Users/evrsen/.config/zed/settings.json", id: 2
2024-02-28T22:07:34+01:00 [INFO] querying GitHub for latest version of language server "json-language-server"
2024-02-28T22:07:34+01:00 [INFO] Node runtime install_if_needed
2024-02-28T22:07:36+01:00 [INFO] checking if Zed already installed or fetching version for language server "json-language-server"
2024-02-28T22:07:36+01:00 [INFO] Node runtime install_if_needed
2024-02-28T22:07:36+01:00 [INFO] starting language server. binary path: "/Users/evrsen/Library/Application Support/Zed/node/node-v18.15.0-darwin-arm64/bin/node", working directory: "/Users/evrsen/.config/zed", args: ["/Users/evrsen/Library/Application Support/Zed/languages/json-language-server/node_modules/vscode-json-languageserver/bin/vscode-json-languageserver", "--stdio"]
2024-02-28T22:07:50+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:07:50+01:00 [INFO] Waiting for default prettier to install
2024-02-28T22:07:50+01:00 [INFO] Starting prettier at path "/Users/evrsen/Library/Application Support/Zed/prettier"
2024-02-28T22:07:50+01:00 [INFO] Node runtime install_if_needed
2024-02-28T22:07:50+01:00 [INFO] starting language server. binary path: "/Users/evrsen/Library/Application Support/Zed/node/node-v18.15.0-darwin-arm64/bin/node", working directory: "/", args: ["/Users/evrsen/Library/Application Support/Zed/prettier/prettier_server.js", "/Users/evrsen/Library/Application Support/Zed/prettier"]
2024-02-28T22:07:50+01:00 [INFO] Started default prettier in "/Users/evrsen/Library/Application Support/Zed/prettier"
2024-02-28T22:07:57+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:07:58+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:09:32+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:09:32+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:09:32+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:09:32+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-02-28T22:09:32+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition

[Moshyfawn]

Can you try this?

  "lsp": {
    "rust-analyzer": {
      "initialization_options": {
-       "checkOnSave": "clippy"
+       "checkOnSave": {
+         "command": "clippy" // rust-analyzer.checkOnSave.command
+       }
      }
    }
  }

[nesrve]

Thanks @Moshyfawn that worked, odd that Zed doesn't show me the available keys inside lsp

[Moshyfawn]

I'm not sure, to be honest. You might want to create a separate enhancement issue for the LSP settings autocomplete.

[JosephTLyons]

Yeah, it seems that our autocompletions don't work at all levels of the json schema - that's been an issue ever since I can remember. Let's close this specific issue out, but feel free to make a new one tracking the lack of autocompletions in the nested structure.