Extra space in auto-completion popup

[andrew-ares]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

Goland:

Environment

Zed: v0.124.6 (Zed Preview) OS: macOS 14.3.1 Memory: 36 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[JosephTLyons]

I think that this might be answered in:

• https://github.com/zed-industries/zed/issues/8389

I'm guessing our we currently just make the autocompletion box as big as the documentation box, but I'm not sure. @ForLoveOfCats might have more info on it.

[andrew-ares]

I'm guessing our we currently just make the autocompletion box as big as the documentation box, but I'm not sure.

Sounds about right. But I can't see the reason to make these two boxes the same height.

[bbb651]

This is very easily reproducible with javascript DOM types as they have lengthy MDN documentation snippets that span multiple lines. The issue is triggered when entries having differing height, and seems to cause the total height of the scrollable to be the height of the tallest completion times the number of completions, with most space being between completions, and some of the space from the completions before the tallest completion end up at the end.

Is having a completion height be more than one line intended? Because it feels very unintuitive to me, and pretty much redundant with the documentation popover right besides it.

The worst example I found is things that bring up HTMLMediaElement as it's longer than the height of the completion popover causing it to show either one or zero completions at a time: