zed Add TSX and JSX icons

Release Notes:

Added cpp,c-sharp,jsx,tsx icons

or

N/A

Optionally, include screenshots / media showcasing your addition that can be included in the release notes.

Feb 27 '24 08:02 ashraf7hossain

We require contributors to sign our Contributor License Agreement, and we don't have @ashraf7hossain on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Feb 27 '24 08:02 cla-bot[bot]

added some essential icons to the project.

Feb 27 '24 09:02 ashraf7hossain

@ashraf7hossain Please make the icons 14x14, so that it's consistent with other icons.

Also I think you've forgot to add icons path under types. You've only added the suffix.

Feb 27 '24 14:02 Imgkl

changed icons size to 14x14 and also added type

Feb 28 '24 10:02 ashraf7hossain

changed icons size to 14x14 and also added type

We still need to change the icons to black and white. They still have color.

Also, I think at least the C++ icon (and maybe the C# one) are going to have the same problem I mentioned here https://github.com/zed-industries/zed/pull/8272#issuecomment-1965716583, where the icon doesn't look good in Zed.

Feb 28 '24 15:02 maxdeviant

changed color to black and white and added suitable icons.

Feb 29 '24 13:02 ashraf7hossain

@ashraf7hossain please add sources of the icons as well, it'll be helpful for us in case if you need contributors to help. 😄

Feb 29 '24 14:02 Imgkl

I have added pure svg icons for jsx,cpp and cs and here is the resource link

Mar 02 '24 10:03 ashraf7hossain

@ashraf7hossain Great that you figured out the SVG issue. One more issue I'd like to point out, Look at the icons below as reference. I found your current JSX icon is not similar to what the react framework has.

React - https://www.svgrepo.com/vectors/react/ C++ - https://www.svgrepo.com/svg/521339/c-plusplus-16 c# - https://www.svgrepo.com/svg/521273/c-sharp-16

Mar 02 '24 15:03 Imgkl

Now should I only change react icon or all icons I that I uploaded?

Mar 02 '24 15:03 ashraf7hossain

I have updated react icon please let me know if it works .

Mar 04 '24 13:03 ashraf7hossain

The C++ and C# icons still don't look good enough to accept. I think we should drop them from this PR and focus on just the TSX and JSX icon.

That one is getting closer, but it still doesn't align with our other icons. It seems like it's almost stretched horizontally.

Where did we source that one from?

Mar 04 '24 15:03 maxdeviant

I changed react icon and removed c++ and c# icons , please let me know if it is required something?

Mar 06 '24 09:03 ashraf7hossain

The icon still doesn't look quite right:

I think I'm going to close this until we can design a TSX/JSX icon for our existing icon theme.

Mar 14 '24 17:03 maxdeviant