zed icon indicating copy to clipboard operation
zed copied to clipboard

[WIP] Add Docker file icon

Open Tom-Boscher opened this issue 1 year ago • 6 comments

Add Docker file icon. Source: https://www.docker.com/company/newsroom/media-resources/

Release Notes:

  • N/A
Capture d’écran 2024-02-25 à 18 06 06

Tom-Boscher avatar Feb 25 '24 17:02 Tom-Boscher

We require contributors to sign our Contributor License Agreement, and we don't have @Tom-Boscher on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 25 '24 17:02 cla-bot[bot]

@cla-bot check

Tom-Boscher avatar Feb 25 '24 17:02 Tom-Boscher

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 25 '24 17:02 cla-bot[bot]

Currently, only .dockerignore is recognized as a Docker file. I need to add logic based on name of the file in addition to the logic based on the suffixe.

Tom-Boscher avatar Feb 25 '24 17:02 Tom-Boscher

Hey @Tom-Boscher, I think most Zed file icons sizes are along the lines of 14x14 and 14x15, so maybe a good idea would be resizing the .svg file to any of those sizes, preferably 14x14!

Hugoonreplit avatar Feb 25 '24 21:02 Hugoonreplit

Hey @Tom-Boscher, I think most Zed file icons sizes are along the lines of 14x14 and 14x15, so maybe a good idea would be resizing the .svg file to any of those sizes, preferably 14x14!

Indeed, I fixed that

Tom-Boscher avatar Feb 25 '24 22:02 Tom-Boscher

Capture d’écran 2024-02-28 à 02 21 46

Tom-Boscher avatar Feb 28 '24 01:02 Tom-Boscher

Thanks for opening this PR, @Tom-Boscher.

It looks like icons for Dockerfiles were added already in #8453.

maxdeviant avatar Feb 28 '24 01:02 maxdeviant