zed-industries
completion box: add strikethrough for deprecated methods
Check for existing issues
- [X] Completed
Describe the bug / provide steps to reproduce it
for example:
trait std::ascii::AsciiExt is deprecated. Here is make_ascii_lowercase in VSCode:
Environment
Zed: v0.123.3 (Zed) OS: macOS 14.3.1 Memory: 32 GiB Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response
A PR just landed to add in strikethrough support:
- https://github.com/zed-industries/zed/pull/8287
So the gut instinct that Kirill and I have is that this shouldn't be too hard to add. :)
Hey, I think I could fix this (its my first time contributing) should I just open a PR? Thanks!
Hey, I think I could fix this (its my first time contributing) should I just open a PR? Thanks!
I'd say go for it. You can check the contribution guide for the best way to do this.
@JosephTLyons Can this issue be closed now or do we have more touch points to complete for this issue? Went through the PR I couldn't get clarity there hence asking.
@Moshyfawn Oh okay 👍🏽 I was under the impression issue gets closed on PR merge.
@Moshyfawn Oh okay 👍🏽 I was under the impression issue gets closed on PR merge.
I see! I was under the impression that you were looking to see if the feature had been implemented yet 🙈 Good catch!
not working in some cases:
@Moshyfawn @Adam-Alani
Thanks,
[dependencies]
chrono = "0.4"
NaiveDate::from_y