zed icon indicating copy to clipboard operation
zed copied to clipboard

Fix Dart syntax highlighting issue

Open Imgkl opened this issue 1 year ago • 6 comments

Release Notes: Improved Syntax Highlighting. Closes #8151

Before: Before

After: After

(Shameless plug, since I build the theme) Theme: The Dark Side

Imgkl avatar Feb 24 '24 21:02 Imgkl

@maxbrunsfeld Before the release of version 0.124, integrating this PR would be beneficial as it enhances syntax highlighting for Flutter and Dart applications.

Imgkl avatar Feb 24 '24 21:02 Imgkl

That's awesome, it's improving reading the code. LGTM. I'm using preview version, if it's won't merge soon, I'll cherry-pick and use this.

Edit: I forked and tried, good job, thanks. image

Do you planning to add Flutter debugger ? I'm using flutter run with nodemon nodes package for hot-reload. But we need Flutter debugger like VSCode. I'll try to help if I can about it.

MarlonJD avatar Feb 26 '24 19:02 MarlonJD

@MarlonJD, thanks a ton for checking out the PR! 🌟 Crossing my fingers it gets the green light soon!

As for the Flutter debugger, that’s not my jam right now. There’s an open issue where the pros are hashing it out. So, I’m stepping back to let those in the know do their thing. 😁

Imgkl avatar Feb 27 '24 05:02 Imgkl

@maxbrunsfeld any timeline on when we can get this PR reviewed? Are we waiting for language support as extension?

Imgkl avatar Feb 27 '24 05:02 Imgkl

I've started the work for transitioning dart support as extension. Currently the blocker is the lack of language servers api.

Imgkl avatar Feb 28 '24 18:02 Imgkl

@maxbrunsfeld just checking in, any updates on this?

Imgkl avatar Mar 04 '24 07:03 Imgkl

@Imgkl We've extracted the Dart support out into an extension:

https://github.com/zed-industries/zed/tree/3a6e0bb9b68ddb8c471c71b25d3052f6fae8b703/extensions/dart

Could you rebase this PR against main to account for the change in file locations?

maxdeviant avatar Apr 10 '24 19:04 maxdeviant

Sure, will do. @maxdeviant

Imgkl avatar Apr 11 '24 02:04 Imgkl

Warnings
:warning:

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by :no_entry_sign: dangerJS against ecd3f70717ce4849a1929927c0c3e674012d7ef3

zed-industries-bot avatar Apr 11 '24 18:04 zed-industries-bot

@maxdeviant Done. This branch is rebased with main and pushed my changes.

Imgkl avatar Apr 11 '24 18:04 Imgkl

On my way to tell everyone, "If you are comfortably using Dart on Zed, I'm the reason.". 😄

You're welcome

Imgkl avatar Apr 11 '24 18:04 Imgkl

what version of zed has this?

JoseDFS avatar Apr 24 '24 16:04 JoseDFS

what version of zed has this?

This hasn't been released yet, but will be in v0.0.2 of the Dart extension: https://github.com/zed-industries/zed/pull/10940

I'll get that published soon.

maxdeviant avatar Apr 24 '24 16:04 maxdeviant