zed icon indicating copy to clipboard operation
zed copied to clipboard

Add C++ file icon

Open Kalmaegi opened this issue 1 year ago • 7 comments

add cpp file icon, source file from: https://github.com/file-icons/icons/blob/master/svg/C%2B%2B.svg I've tweaked the Bring You format a bit to make it more suitable for display in ZED

Kalmaegi avatar Feb 23 '24 13:02 Kalmaegi

Can we size the icon down a bit? It looks way too large in comparison with our other icons.

maxdeviant avatar Feb 23 '24 13:02 maxdeviant

cc, cxx,and C are also common C++ file suffixes, the icon should apply to those as well.

jansol avatar Feb 23 '24 13:02 jansol

Can we size the icon down a bit? It looks way too large in comparison with our other icons.

Can we size the icon down a bit? It looks way too large in comparison with our other icons.

sure, this before: image

this now: image

Kalmaegi avatar Feb 23 '24 13:02 Kalmaegi

The icon still seems too large when compared to our existing icons.

The C++ icon is at 512x512, while most of our other icons are 14x14.

maxdeviant avatar Feb 25 '24 16:02 maxdeviant

The icon still seems too large when compared to our existing icons.

The C++ icon is at 512x512, while most of our other icons are 14x14.

sorry not get your mean before, resized it

Kalmaegi avatar Feb 26 '24 01:02 Kalmaegi

The icon doesn't look quite right:

Screenshot 2024-02-26 at 10 18 39 PM

You can barely make out the ++ in the icon. I think we need a different icon that is clearer at small sizes.

maxdeviant avatar Feb 27 '24 03:02 maxdeviant

The icon doesn't look quite right:

Screenshot 2024-02-26 at 10 18 39 PM You can barely make out the `++` in the icon. I think we need a different icon that is clearer at small sizes.

I think so, although the icon is broad, but ++ is too small, I extracted the internal symbols and removed the borders, but even then, the ++ was small and illegible, so I found another icon, it has the same line width as other languages icon, how do you feel about this one? And I found that the icons of file are not perfectly aligned, and the icons of some languages will be smaller e.g. haskell

also too small: image

newest: image

Kalmaegi avatar Feb 27 '24 06:02 Kalmaegi

Since we can't seem to find an existing C++ icon that looks good, I think we're going to let the designer who made our other icons look into making a custom one.

There is an open issue (https://github.com/zed-industries/zed/issues/8843) for allowing extensions to provide icons, so that may be another avenue in the future.

Going to close this PR out.

maxdeviant avatar Mar 07 '24 18:03 maxdeviant