zed icon indicating copy to clipboard operation
zed copied to clipboard

Improve `TS` buffer symbols

Open rpfaeffle opened this issue 1 year ago • 2 comments

This PR adds support for a more detailed buffer symbol search. Feedback is very much appreciated.

The following screenshots are based on https://github.com/learn-anything/learn-anything.xyz/blob/main/shared/ui/Search.tsx

After: SCR-20240221-mcvs

Before: SCR-20240221-mdcr

Release Notes:

  • Improved buffer symbol search for ts / tsx (#4483).

rpfaeffle avatar Feb 21 '24 12:02 rpfaeffle

FWIW personally I like the current amount of buffer symbols Zed display, as it's much easier to get a glimpse of what's in the file, which is what I use the feature for. When moving from VSCode to Zed, this is actually one of the things I appreciated.

For example, I'm not interested in seeing every property of interface SearchState when checking what symbols is in the file from a glance.

Zed: image

VSCode: image

pimmee avatar Feb 25 '24 20:02 pimmee

I definitely see your point. Maybe my current approach is a bit too detailed and could be reduced to TSX and variables inside functions (to get an overview of the possible states).

rpfaeffle avatar Feb 25 '24 20:02 rpfaeffle

I'm going to close this one based on @pimmee's feedback.

ConradIrwin avatar Mar 15 '24 03:03 ConradIrwin