zed icon indicating copy to clipboard operation
zed copied to clipboard

Add `workspace: save without formatting` and default autosave without formatting

Open dylan-conway opened this issue 1 year ago • 2 comments

  • Added autosave.after_delay/on_window_change/on_focus_change.trigger_formattercloses #4882 One quirk to this implementation is you can have a configuration like this and the document won't format on save. A more accurate name for this setting is trigger_format_on_save. Open to changing it. Screenshot 2024-02-17 at 9 41 00 PM

  • Added workspace: save without formatting. closes #5230 The default key binding is the same as vscode (cmd-k s), open to changing this as well.

dylan-conway avatar Feb 18 '24 07:02 dylan-conway

Sorry y'all, didn't realize you had already worked on this feature when I opened https://github.com/zed-industries/zed/pull/8806.

I'm gonna merge my PR, as it's essentially the same functionality and approach. But I'll leave this one open for incorporating the autosave setting into the SaveWithoutFormat functionality :)

mikayla-maki avatar Mar 04 '24 05:03 mikayla-maki

Sorry y'all, didn't realize you had already worked on this feature when I opened #8806.

I'm gonna merge my PR, as it's essentially the same functionality and approach. But I'll leave this one open for incorporating the autosave setting into the SaveWithoutFormat functionality :)

No problem 👍 I haven't updated this pr in two weeks

dylan-conway avatar Mar 04 '24 06:03 dylan-conway

Going to close this for now as it'll need significant rebasing to merge; but as Mikayla said, the setting would be nice.

ConradIrwin avatar Mar 13 '24 17:03 ConradIrwin