zed
zed copied to clipboard
zed-industries
Better ui design when hovering over words
Check for existing issues
- [x] Completed
Describe the feature
It would be nice if the popup and text would be one :))
If applicable, add mockups / screenshots to help present your vision of the feature
Before:
After:
No one's currently working on this right? @JosephTLyons
Nope, not to my knowledge. Would you like me to assign it to you?
Would love to work on this but I haven't explored the codebase fully yet! It's my first time trying to contribute to Zed so I guess I'll have to spend some more time exploring the codebase first.. If it's not too much to ask, can you please point me to the right crate dir I should be looking at for this enhancement?
You're looking for https://github.com/zed-industries/zed/blob/e5d971f4c71aa2bb3c3aaea9d0838502c194992c/crates/editor/src/hover_popover.rs file, there are multiple flavors of those with their own render method responsible for drawing the thing.
You're looking for https://github.com/zed-industries/zed/blob/e5d971f4c71aa2bb3c3aaea9d0838502c194992c/crates/editor/src/hover_popover.rs file, there are multiple flavors of those with their own
rendermethod responsible for drawing the thing.
Yep found it out! But thanks anyway.. 🙂
What happens in a scenario like this? If the Popover Anchor & the Popover Element is combined together, do you think it will look odd? @JosephTLyons @mateo-meillon
@SouravInsights I would probably just make the top one artificially longer
@SouravInsights I would probably just make the top one artificially longer
Could probably work!! How do we get some concrete feedback on this? @mateo-meillon @JosephTLyons
Good question - Going to lean on @SomeoneToIgnore for some advice here!
VSCode:
RustRover:
It looks like we can add some padding, customize the border a bit, and maybe add more contrast? Not sure we need to get into anything fancy as that arrow-like edge of the bubble though.