zed icon indicating copy to clipboard operation
zed copied to clipboard

Broken editor/terminal rendering after project search

Open N8th8n8el opened this issue 1 year ago • 11 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

See screenshot. Recovered after searching for something else. Not reproducible, but had it once a few days ago already.

https://github.com/zed-industries/zed/assets/19362696/ff23b6c1-740e-4716-a6d8-bd23de71e7c4

Environment

Zed: v0.123.1 (Zed Preview) OS: macOS 14.3.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

N8th8n8el avatar Feb 15 '24 07:02 N8th8n8el

When I can reproduce it's always when the first search result is a huge minified js file (where everything is in one line).

N8th8n8el avatar Feb 15 '24 07:02 N8th8n8el

Also only happens when the window is quite large (almost full 4k screen). Everything is fine on a smaller window size. Another recording:

https://github.com/zed-industries/zed/assets/19362696/9e872c01-a772-4382-89da-85c1fe92954c

(sorry for the bad quality, GitHub only allows 10MB)

N8th8n8el avatar Feb 15 '24 07:02 N8th8n8el

This is a super strange bug. If you find that there's a way to reproduce it, let us know, but I'm guessing this is some random state that isn't easy to trigger.

JosephTLyons avatar Feb 16 '24 17:02 JosephTLyons

Had something similar just now, but not triggered by search:

https://github.com/zed-industries/zed/assets/19362696/19e4047b-9f0d-4e93-a359-374343d1f1e5

Lot's of output in the terminal and Zed taking up the whole 4k screen (not macOS full screen).

N8th8n8el avatar Feb 17 '24 08:02 N8th8n8el

And again:

https://github.com/zed-industries/zed/assets/19362696/67333eec-54c8-4b87-b0e9-1d1d9deacc8e

N8th8n8el avatar Feb 17 '24 08:02 N8th8n8el

https://github.com/zed-industries/zed/assets/104262550/cc1b650a-4201-49bc-93fb-0e9f5969edb3

Another instance. Seems to happen when I open a file with a single long line (e.g. js bundle) AND if the windows is full screen (but not the macos full screen mode) on a 4k monitor.

nathanael-ruf avatar Mar 18 '24 07:03 nathanael-ruf

Screenshot 2024-03-21 at 11 54 51

Another instance that shows that not only the terminal starts acting weirdly. The first search result was a js bundle again with one long line. And again only happening when full screen on a 4k monitor. It goes away when I resize the window to roughly 80% of the full sreen.

nathanael-ruf avatar Mar 21 '24 10:03 nathanael-ruf

Another instance that is perhaps easier to reproduce:

https://github.com/zed-industries/zed/assets/104262550/c4a6924a-e15f-4ffb-8bf6-327842308fd1

adsasdddasadsasdddasadsasdddasadsasdddasadsasdddasadsasdddasadsasdddasadsasdddasasdddddddddddddddadadasdasdads

echo "asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
asadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsadsdasadsddsadassssasadsdasadsa
"

nathanael-ruf avatar Mar 22 '24 09:03 nathanael-ruf

@JosephTLyons I think we need to rename this as it seems to have nothing todo with search.

I'm hitting this multiple times a day. Some import lines that are a bit longer can already trigger this.

nathanael-ruf avatar Mar 22 '24 09:03 nathanael-ruf

Yikes! Thanks for elevating this @nathanael-ruf - seems pretty bad.

JosephTLyons avatar Mar 25 '24 19:03 JosephTLyons

Is there any update on this? I installed Zed on MacOS 11.7.10 and immediately ran into this issue opening a TS file. Would love to give the editor a fair shot

kag359six avatar May 11 '24 22:05 kag359six

Pretty sure this was fixed by https://github.com/zed-industries/zed/pull/11849. Closing, but happy to reopen if it's still there on latest Preview.

mrnugget avatar May 16 '24 07:05 mrnugget

@mrnugget I'm still observing this issue on my 2013 Macbook Pro running MacOS 11.7.10 (Intel chip):

Here's a loom re-production

kag359six avatar May 17 '24 17:05 kag359six

@kag359six even on the newest Preview release? There should be errors in ~/Library/Logs/Zed/Zed.log — are there any?

mrnugget avatar May 21 '24 08:05 mrnugget