Terminal font styling (bold, italics) isn't applied when the set buffer_font_family doesn't exist

[clo4]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

This turns out to be quite a useful setting to keep incorrect for QA :P

When your buffer_font_family is set to a nonsense value, text in the terminal doesn't apply styling like bold/italics. I'm imagining this probably applies to more than just the terminal but I haven't tried to reproduce outside of that context.

Environment

Zed: v0.122.0 (Zed Nightly) OS: macOS 14.3.0 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[Calinou]

I can confirm this on the following specs:

Zed: v0.143.7 (Zed) OS: Linux X11 fedora 40 Memory: 62.5 GiB Architecture: x86_64

I'm using JetBrains Mono as the buffer font family, which is a valid font name on the system and works in other applications. I have the bold variant installed too.

On the other hand, it does work with CommitMono:

Comparison to kitty where JetBrains Mono works:

I have JetBrains Mono installed from a google/fonts local clone, while Commit Mono was downloaded from its developer:

$ ls ~/.local/share/fonts/Commit\ Mono 
CommitMono-400-Italic.otf  CommitMono-400-Regular.otf  CommitMono-700-Italic.otf  CommitMono-700-Regular.otf

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

[clo4]

I can still reproduce this bug.

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

[Calinou]

I can still reproduce this.

[P1n3appl3]

This also repros with the terminal specific font family setting:

"terminal": {
  "font_family": "not_a_font_on_my_system",
}