zed icon indicating copy to clipboard operation
zed copied to clipboard

Add roc lang #7378

Open h2000 opened this issue 1 year ago • 5 comments

Release Notes:

  • Fixed: #7378

h2000 avatar Feb 05 '24 12:02 h2000

We require contributors to sign our Contributor License Agreement, and we don't have @h2000 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 05 '24 12:02 cla-bot[bot]

@cla-bot check

h2000 avatar Feb 05 '24 12:02 h2000

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 05 '24 12:02 cla-bot[bot]

Still a WIP, needs some polishing and more testing.

h2000 avatar Feb 05 '24 12:02 h2000

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alf Richter. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Feb 05 '24 19:02 cla-bot[bot]

Hello, thank you for submitting the PR, but we would like to have roc lang support as a standalone plugin, not included into Zed source tree.

Some Zed team members currently work on plugin support, the first big step is made: https://github.com/zed-industries/zed/pull/7105 and more to follow in https://github.com/zed-industries/zed/issues/7096

In the end, we want to remove all but "main" languages from Zed source tree and instead provide a plugin API to support them. Unfortunately, it takes time so we decided to let in some "popular" languages for the time being so that people can use Zed more and we can find more issues with the LSP integrations in our code.

Unfortunately, every new lang support PR comes with a cost:

  • extra compilation costs: at first, people have to check-put dozens MB of tree-sitter dependencies (if not hundreds at this point), compile those occasionally (cargo clean) and always link those in. That slowly get worse with every such PR merged.

  • maintenance — neither PR comes 100% ready and requires further PRs on top that somebody has to make and another has to review. Some of them (e.g. https://github.com/zed-industries/zed/issues/7295) stay stale, which makes the experience bad, given that its code in the "official" repo.

It also seems that current PR brings some shenanigans already: https://github.com/zed-industries/zed/pull/7379/files#diff-f7430634909ddcbcb21d457574adfad0d8ba296d5c57e204da87c0df48912492R282 , which is another reason to keep it separate.

SomeoneToIgnore avatar Feb 06 '24 10:02 SomeoneToIgnore