zed icon indicating copy to clipboard operation
zed copied to clipboard

Upgrade nodejs so unneeded nodejs files aren't downloaded

Open koramangalacode opened this issue 1 year ago • 3 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

Unneeded nodejs files are being downloaded, wasting data for those stuck with metered internet #6803 https://github.com/nodejs/node/issues/46451

Environment

macOS

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

koramangalacode avatar Feb 02 '24 23:02 koramangalacode

Looking at the linked Node issue (https://github.com/nodejs/node/issues/46451), it seems like those files are still present in the Node distributions?

I only saw mention of removing them from the Docker images, which Zed does not use.

maxdeviant avatar Feb 05 '24 21:02 maxdeviant

I'm not sure how but those files end up on my mac but someone else has confirmed it happens to them too.

#7054

koramangalacode avatar Feb 05 '24 22:02 koramangalacode

Zed installs the Node runtime when it is needed for certain language servers, and those files are distributed with Node, AFAICT.

maxdeviant avatar Feb 05 '24 23:02 maxdeviant

This is blocked on upstream changes in Node, so going to close it out as there's nothing for us to do at the moment.

maxdeviant avatar Mar 12 '24 16:03 maxdeviant