zed icon indicating copy to clipboard operation
zed copied to clipboard

Add macOS borderless fullscreen mode

Open diocletiann opened this issue 1 year ago • 6 comments

Check for existing issues

  • [X] Completed

Describe the feature

It's more useful than native since you can still have windows behind it and cmd-tab without changing spaces and waiting for the slide animation. It would also allow for opening new Zed windows in the current space without new spaces being created at the tail.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

diocletiann avatar Feb 02 '24 01:02 diocletiann

Hey @diocletiann, I'm trying to understand the request here. Are you wanting an action that just expands the window out to the full height and width of the screen, but without entering into macOS' full screen mode? And if so, how do you see that being trigggerd? A command palette action, key binding, or UI element?

JosephTLyons avatar Feb 02 '24 03:02 JosephTLyons

@JosephTLyons I'm referring to the old macOS fullscreen mode that didn't create a dedicated space, aka borderless. What some apps do is have a config option for the fullscreen mode type and the user can choose native or borderless.

diocletiann avatar Feb 02 '24 04:02 diocletiann

Ah, you want the non-native fullscreen, right? I love that. I added it to Ghostty and my proof-of-concept is here: https://github.com/mrnugget/non-native-fullscreen In Ghostty it's grown more complex because you need to respect the notch on MacBooks, stuff moving from window to window, etc. But I think it could be relatively straightforward.

mrnugget avatar Feb 02 '24 07:02 mrnugget

Thank you fellow traveler! The Ghostty implementation works great btw.

diocletiann avatar Feb 02 '24 17:02 diocletiann

I would love this feature too, here's some context from the kitty project:

https://github.com/kovidgoyal/kitty/issues/3100

that issue provides a link to the iterm implementation:

https://github.com/gnachman/iTerm2/blob/75b2165fe62f45043dbe59c9e38d018bd82e7f15/sources/PseudoTerminal%2BWindowStyle.m#L517

quinn avatar Apr 26 '24 15:04 quinn

Any movement here? This would be amazing to have.

elliotbonneville avatar May 16 '24 15:05 elliotbonneville