zed icon indicating copy to clipboard operation
zed copied to clipboard

Added bicep tree-sitter support

Open SPR-Ideas opened this issue 1 year ago • 3 comments

Release Notes:

  • Added Tree-Sitter syntax highlight for bicep files. Screenshot 2024-02-01 at 11 28 47 PM

SPR-Ideas avatar Feb 01 '24 18:02 SPR-Ideas

We require contributors to sign our Contributor License Agreement, and we don't have @SPR-Ideas on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 01 '24 18:02 cla-bot[bot]

'@cla-bot check'

SPR-Ideas avatar Feb 02 '24 00:02 SPR-Ideas

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 02 '24 00:02 cla-bot[bot]

That seems like a language which could use an LSP integration, so I'm not sure whether we should merge this at its stage: neither Zed uses this nor there's an issue with 👍 to understand how popular demand this is in Zed. Adding yet another tree-sitter repo to the main source tree bloats compile times for people, and places some support toll on it, which is harder to bear if it's not very needed.

Currently, we're pushing language plugins functionality further, see https://github.com/zed-industries/zed/pull/7105 so tree-sitter-only changes like this should be supported as standalone plugins in Zed — and if they are not working already, we should concentrate fixing that, not bringing more tree-sitter dependencies in Zed repo.

Ergo, I'll close the PR at this state, please either

  • bring in LSP support and reopen it
  • work on the plugin system to make it work together with this grammar
  • make a bicep lang support issue, gather a dozen or two 👍's and reopen this one

SomeoneToIgnore avatar Feb 02 '24 07:02 SomeoneToIgnore