zed
zed copied to clipboard
zed-industries
Dart support
This is my first contribution, feedback is welcome.
Release Notes:
- Added Dart language support (#5343).
We require contributors to sign our Contributor License Agreement, and we don't have @agent3bood on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
Like the CI, I am having issues building:
$ cargo run --release
Updating crates.io index
Updating git submodule `[email protected]:tree-sitter/tree-sitter`
error: failed to get `tree-sitter-dart` as a dependency of package `zed v0.122.0 (/Users/brettmorgan/Documents/GitHub/zed/crates/zed)`
This is my first contribution, feedback is welcome.
Release Notes:
- Added Dart language support (#5343).
Waiting for this to be merged soon, hopefully!
Building works on my machine, could it be related to CI not having github in known_hosts? Or ssh key not setup?
Building works on my machine, could it be related to CI not having github in known_hosts? Or ssh key not setup?
Yeah, I don't have SSH keys setup. The more interesting question is, why is the CI failing? Surely they have SSH keys setup for the CI bots?
Made a fork to fix some issues in the original tree-sitter-dart, should work now.
hey guys what is missing from this just read this like a rollercoster of emotion
@agent3bood Thanks for the PR! Can you rebase or merge main?
Also, could you include screenshots of the syntax highlighting and outline view?
Just a heads up - we are very soon going to be moving most of Zed's built-in languages into installable extensions (https://github.com/zed-industries/zed/issues/7096). Dart is a major enough language that I'm ok with merging this in the meantime. But once the extension system lands, we will probably remove this code and put it into a new dart repository under the new zed-extensions GitHub org. We'll probably add you as a collaborator on that repo when we do it, if you're interested in helping maintain it.
@maxbrunsfeld done, looking forward for getting this merged and contributing even more to the project.
Huge thanks for this effort!
As soon as this gets merged in, I am poised to give Zed a try. Getting a bit tired of the slowness of VSCode.
@maxbrunsfeld Updated the highlights as suggested. Also check the file outline view bellow.
When ship? 🚢🚢🚢
with extensions in pre (love it) - Lets' go for Flutter! 🚀🚀🚀
we all agree that this will change the course of the human timeline right ?
As Dart developers we're all excited about this. Please stop spamming the issue - and in general only comment on Github issues if you contribute to solving it in some meaningful way.
@agent3bood Just my opinion: downgrade to a extensions: https://github.com/zed-industries/extensions
@agent3bood Just my opinion: downgrade to a extensions: https://github.com/zed-industries/extensions
Looks like that will be the better option, just need a couple of days to check it out.
Looks like zed extensions does not support adding language server to the editor, we will wait for this to be merged.
Languages Extensions may provide languages to extend Zed with support for a particular language. Currently this is used for things like syntax highlighting and outlining. Support for defining language servers in extensions will be coming in the future.
Yes, we can move this into an extension later, once we have the extension APIs needed for adding new language servers. Thanks for your work on this @agent3bood.