zed icon indicating copy to clipboard operation
zed copied to clipboard

Fix flicker on names over cursors

Open mikayla-maki opened this issue 1 year ago • 4 comments

Describe the bug / provide steps to reproduce it

When multiple cursors have their username rendering in the same place, it flickers.

Should just be a sort in the right place.

mikayla-maki avatar Jan 29 '24 17:01 mikayla-maki

I'd like to contribute, and am new to contributing to open-source projects. What further details can be provided (files), and how do you suggest a newcomer fix this issue? Thanks. :)

meaghans avatar Jan 30 '24 02:01 meaghans

Hi @meaghans, I'd start by looking in the crates/editor/src/element.rs file, specifically for the lines where Cursor::paint is called. I think the easiest way to fix this would be to just sort the cursors before painting them, perhaps by username, so they always show up in the same order. If it's still unclear, head over to our discord or our fireside hacks, or drop in on us sometime and we can work on it together :)

mikayla-maki avatar Jan 30 '24 04:01 mikayla-maki

@meaghans Hi! May I know if you're still interested in taking this issue?

zephaniahong avatar Feb 25 '24 06:02 zephaniahong

I would like to contribute on this issue as my first open-source contribution. Any suggestions on how to approach this?

vark1623 avatar Feb 26 '24 20:02 vark1623

@vark1623 you can follow the suggestions given above by Mikayla

zephaniahong avatar Feb 27 '24 01:02 zephaniahong

@zephaniahong Understood. I'll start soon.

vark1623 avatar Feb 27 '24 03:02 vark1623