Split divider missing when left pane is active

[diocletiann]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

~~It shows up for a moment with the scroll bar but then disappears~~ edit: that was the scrollbar area border, the split divider doesn't show up. When the right pane is active it looks normal.

Environment

Zed: v0.120.3 (Zed Preview) OS: macOS 14.3.0 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[maxdeviant]

I haven't been able to reproduce this yet in Zed Preview v0.120.3:

[diocletiann]

I haven't been able to reproduce this yet in Zed Preview v0.120.3:

Ah, I see why. It happens when using "active_pane_magnification".

[maxdeviant]

I haven't been able to reproduce this yet in Zed Preview v0.120.3:

Ah, I see why. It happens when using "active_pane_magnification".

What do you have your active_pane_magnification value set at?

[diocletiann]

I haven't been able to reproduce this yet in Zed Preview v0.120.3:

Ah, I see why. It happens when using "active_pane_magnification".

What do you have your active_pane_magnification value set at?

1.8

[tugkanpilka]

I've tracked down the bug and found that it is all about the code block:

for (ix, child_layout) in layout.children.iter_mut().enumerate() {
    if active_pane_magnification.is_none() {
        if ix < len - 1 {
            child_layout.handle =
                Some(Self::layout_handle(self.axis, child_layout.bounds, cx));
        }
    }
}

When i delete the if condition the bug disappeared.

for (ix, child_layout) in layout.children.iter_mut().enumerate() {
    if ix < len - 1 {
        child_layout.handle =
            Some(Self::layout_handle(self.axis, child_layout.bounds, cx));
    }
}

But i did not understand why there is a condition for if active_pane_magnification.is_none() and is it have any side effects when deleted. Any thoughts?