zed icon indicating copy to clipboard operation
zed copied to clipboard

Bigger Close Button ?

Open titouandk opened this issue 1 year ago • 1 comments

Check for existing issues

  • [X] Completed

Describe the feature

The close button is smaller than the back button. I think It would benefit from having the same size of the back button (easier to click):

Small close button        |      Large back button
close-btn back-btn

If applicable, add mockups / screenshots to help present your vision of the feature

No response

titouandk avatar Jan 26 '24 22:01 titouandk

Same thing for the following action buttons, which seems to have inconsistent sizes/shapes:

1 2

titouandk avatar Jan 27 '24 21:01 titouandk

I have the same confusion. The buttons are too small and awkward.

d1y avatar Jan 29 '24 07:01 d1y

a. don't you want a small close button because it's a non desirable action to perform (you don't want people accidentally closing a file)

b. if you want the "x" the same size, now your Tab labels won't be centered - because you'll need more padding to the right of the file name in the tab. Which will make it look like a UI mistake by not having the filename string being centered aligned in the tab.

michealp-coder avatar Jan 30 '24 20:01 michealp-coder

@michealp-coder To answer both of your points:

a. This is not a problem since a confirmation is asked when you close a modified unsaved file.

b. The filename could be left-aligned. This would be more consistent with a lot of softwares on MacOS:

  • Tabs taking all width are generally text centered (Terminal, Safari)
  • Tabs with a fixed width are generally left-aligned (Chrome, Sublime Text, VS Code, Firefox, ...)

titouandk avatar Feb 08 '24 23:02 titouandk

b. The filename could be left-aligned. This would be more consistent with a lot of softwares on MacOS:

Left-aligned is not more consistent.

Apple's Human Interface Guidelines (HIG) state that tab headings should be center aligned.

https://developer.apple.com/design/human-interface-guidelines/tab-views

michealp-coder avatar Feb 09 '24 13:02 michealp-coder

@michealp-coder Tabs in zed are aligned on the left side.

And softs that choose this patterns globally align text on the left.

titouandk avatar Feb 10 '24 12:02 titouandk

I feel that everything in Zed is too small except texts 😅

widersky avatar Mar 20 '24 09:03 widersky