zed icon indicating copy to clipboard operation
zed copied to clipboard

Remove node/openssl/archs directories from the node download

Open dj-documentation opened this issue 1 year ago • 5 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

node/openssl/archs contains almost 50 MB of unneeded files. Removing them would help people on slow metered internet connections.

$ du -h ~/Library/Application\ Support/Zed/node/node-v18.15.0-darwin-arm64/include/node/openssl/archs | tail -1
 49M	/Users/mac/Library/Application Support/Zed/node/node-v18.15.0-darwin-arm64/include/node/openssl/archs
$ ls ~/Library/Application\ Support/Zed/node/node-v18.15.0-darwin-arm64/include/node/openssl/archs         
BSD-x86			VC-WIN64A		darwin64-x86_64-cc	linux-ppc64le		linux64-riscv64
BSD-x86_64		aix64-gcc-as		linux-aarch64		linux-x86_64		linux64-s390x
VC-WIN32		darwin-i386-cc		linux-armv4		linux32-s390x		solaris-x86-gcc
VC-WIN64-ARM		darwin64-arm64-cc	linux-elf		linux64-mips64		solaris64-x86_64-gcc

Environment

macOS

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

dj-documentation avatar Jan 26 '24 19:01 dj-documentation

Are you sure these are present in the .dmg?

That directory is where we install the Node runtime that gets downloaded when it's needed: https://github.com/zed-industries/zed/blob/5db7e8f89ee4f5d9801a2eab88adc1db3fda0f46/crates/node_runtime/src/node_runtime.rs#L59-L115

maxdeviant avatar Jan 26 '24 19:01 maxdeviant

You're right those files only show up after running the app. I'm on a slow metered connection so saving 50 MB is still helpful.

dj-documentation avatar Jan 26 '24 20:01 dj-documentation

The title and description of the issue have been updated

dj-documentation avatar Jan 26 '24 20:01 dj-documentation

It's a nodejs issue https://github.com/nodejs/node/issues/46451

dj-documentation avatar Jan 26 '24 20:01 dj-documentation

node/openssl/archs contains almost 50 MB of unneeded files. Removing them would help people on slow metered internet connections.

If the files are already being downloaded by Node, what would be the purpose in having Zed remove them once they are downloaded?

maxdeviant avatar Jan 27 '24 00:01 maxdeviant

Could you provide users the choice before downloading the large files? I assumed everything was included in the DMG since it was over 100 MB.

dj-documentation avatar Jan 27 '24 22:01 dj-documentation

The issue will be resolved when nodejs is upgraded

dj-documentation avatar Jan 27 '24 22:01 dj-documentation

See #7054 for why these files are downloaded

dj-documentation avatar Jan 30 '24 19:01 dj-documentation