Read HTTP proxy from env

[dylankyc]

This PR will use http proxy from env for downloading files.

[cla-bot[bot]]

We require contributors to sign our Contributor License Agreement, and we don't have @lichuan6 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[dylankyc]

@cla-bot check

[cla-bot[bot]]

The cla-bot has been summoned, and re-checked this pull request!

[ConradIrwin]

@lichuan6 Thanks for this!

I think we should configure the proxy on the HTTP client, instead of on get requests. This will ensure it is used for everything (including post_json automatically).

In the environment you're working in, do web sockets work correctly? I don't think we can try and establish the web socket connection through an http proxy, but I am curious if we need to do anything to make them work too.

[dylankyc]

@ConradIrwin

I've configured the proxy on the HTTP client, instead of on get or post_json methods.

As for web sockets through http proxy, is there a way to verify if WebSocket communication works through an HTTP proxy?

Thanks

[mikayla-maki]

@lichuan6 in development builds, if you click on the sign in button on the top right, sign into our service via github or keychain, and then open the collab panel on the bottom right, you should be able to test it. If you're able to make new channels and such in that UI, then you're good. The collaboration features all use websockets.

[dylankyc]

Hi @mikayla-maki I tried to sign in on the top right, however, I failed with the following error.

Any idea how to fix it?

[mikayla-maki]

Try rebasing your branch :) we recently updated our protocol pretty significantly, and we're only able to with the latest version of the protocol.

[ConradIrwin]

Thanks for this, and sorry for all the back and forth here!