zed icon indicating copy to clipboard operation
zed copied to clipboard

Add protobuf support

Open MordFustang21 opened this issue 2 years ago • 2 comments

Release Notes:

  • Added protobuf syntax highlighting (#5160).

MordFustang21 avatar Jan 26 '24 06:01 MordFustang21

Looks much better now, thank you 🚀

image

I think we would need to add a bit more:

  • optional keyword highlights
  • oneof variant highlighting also asks for more colors
  • outline.scm so a person could navigate over the next with cmd-shift-o menu + enable the gutter showing regions on top
  • ? maybe, add some slight color change to the field names, so they do not mix with the unknown identifiers
  • and a small formatting nit the CI complained about needs to be fixed

SomeoneToIgnore avatar Jan 26 '24 08:01 SomeoneToIgnore

I've addressed most of the above comments. There are still some outstanding issues though that I'm not quite sure how to tackle.

  1. oneof variant highlighting also asks for more colors
  2. ? maybe, add some slight color change to the field names, so they do not mix with the unknown identifiers

@mikayla-maki I added an outline file with some queries that felt most relevant. Happy to pair on it sometime if you feel there's more to add.

MordFustang21 avatar Jan 27 '24 20:01 MordFustang21

Thank you for this PR! :D

mikayla-maki avatar Jan 30 '24 01:01 mikayla-maki

Let's add a new doc entry into https://github.com/zed-industries/zed/tree/main/docs/src/languages list and merge this 🎉

SomeoneToIgnore avatar Jan 30 '24 08:01 SomeoneToIgnore

Added doc file

MordFustang21 avatar Jan 30 '24 18:01 MordFustang21