zed icon indicating copy to clipboard operation
zed copied to clipboard

Git in-line blame indicators

Open krstp opened this issue 1 year ago • 7 comments

Check for existing issues

  • [X] Completed

Describe the feature

Feature request for in-line git blame indicators upon cursor placement

If applicable, add mockups / screenshots to help present your vision of the feature

commit-msg

krstp avatar Apr 14 '23 02:04 krstp

I'd also like to show Git code authorship at top of file, same as https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens#git-codelens

image

cktang88 avatar Apr 21 '23 04:04 cktang88

https://marketplace.visualstudio.com/items?itemName=waderyan.gitblame

I like using the Git Blame extension more than the way GitLens does it.

vuon9 avatar Jan 25 '24 08:01 vuon9

I wanted to chime in and say that I would really appreciate this to be a native feature built into the editor itself as part of its git integration suite. I feel like inline annotations should be a core feature of any modern editor with good git integration due to the popularity of the feature in other editors.

I find that, in other editors with extensions providing this feature, the extensions become extremely popular and, after some time, become heavily commercialised and bloated with unnecessary features. They may also not implement the feature properly, causing issues with git blame options such as the blame.ignoreRevsFile config option. Having a native, built-in implementation would allow these sorts of errors and oversights to be more effectively noticed and resolved.

deadmeu avatar Feb 18 '24 05:02 deadmeu

I wanted to chime in and say that I would really appreciate this to be a native feature built into the editor itself as part of its git integration suite. I feel like inline annotations should be a core feature of any modern editor with good git integration due to the popularity of the feature in other editors.

I find that, in other editors with extensions providing this feature, the extensions become extremely popular and, after some time, become heavily commercialised and bloated with unnecessary features. They may also not implement the feature properly, causing issues with git blame options such as the blame.ignoreRevsFile config option. Having a native, built-in implementation would allow these sorts of errors and oversights to be more effectively noticed and resolved.

I second this. Having this feature as a native implementation would be so much better that having all the suite of GitLens in VSCode

Edit

Also as a response for @vuon9 it would be great if this could be configurable. I'm more of in line style but having the two options (in line and status bar) it's a 10/10

slingercode avatar Feb 28 '24 14:02 slingercode

Sharing in case it's helpful to anyone:

Until Zed supports this feature I'm defining a Zed task to get (fairly) quick access to the blame around my current position in a file:

.config/zed/tasks.json

[
  {
    "label": "Blame Around Line",
    "command": "git blame $ZED_FILE -L $(($ZED_ROW - 5)),$(($ZED_ROW + 5))"
  }
]

It's then fairly easy to run task: spawn -> Blame Around Line

westonkd avatar Mar 21 '24 21:03 westonkd

Now merged: #10398

mrnugget avatar Apr 15 '24 13:04 mrnugget

Now merged: #10398

Wow, that looks fantastic! Thank you so much for working on this. This is such a great feature to be included by default! :heart_eyes:

deadmeu avatar Apr 15 '24 14:04 deadmeu

If you run into any bugs or want to suggest enhancements around inline git blame, please open new issues!

JosephTLyons avatar Apr 15 '24 17:04 JosephTLyons