zed icon indicating copy to clipboard operation
zed copied to clipboard

Allow updating themes or make existing themes actually have good contrast

Open nikivdev opened this issue 2 years ago • 3 comments

Check for existing issues

  • [X] Completed

Describe the feature

I like using Atelier Plateau Light theme but suggestions look like this:

image

Focused suggestion from search is barely readable. 😞

Can I change it so I can use the suggestions properly?

If I can't change it as theme support is not implemented, can you at least update it to make default themes work well.

Thank you.

nikivdev avatar Sep 13 '23 08:09 nikivdev

Or this:

image

Also unreadable.

nikivdev avatar Sep 13 '23 08:09 nikivdev

Themes aren't user customizable yet - we're doing some preliminary work right now that has to be done before we begin working on user-defined themes.. We will improve contrast of our built in themes at some point, probably after we finish the preliminary work. cc @iamnbutler.

JosephTLyons avatar Sep 14 '23 00:09 JosephTLyons

This really needs to be higher priority, or some of the existing themes should just be removed until it's fixed. Trying to simply locate the highlighted string match in a find is near impossible for a number of the themes:

image

FlyingAvatar avatar Feb 01 '24 15:02 FlyingAvatar

We now have user theme support and allow overriding themes via experimental.theme_overrides in the settings file.

We're still figuring out what the future of the built-in Zed themes is, but we're not looking to make changes to those themes at this point.

maxdeviant avatar Mar 12 '24 17:03 maxdeviant