zed icon indicating copy to clipboard operation
zed copied to clipboard

Close assistant

Open adamsoutar opened this issue 1 year ago • 5 comments

Check for existing issues

  • [X] Completed

Describe the feature

This seems like such a silly ticket to write - hopefully I'm just being dumb and I've missed something 😅

Is it possible to close Assistant?

I hit the magic wand icon because I was curious about what it was, and that opened the panel asking for an API key.

I'm not sure what I'm looking for, but hitting the wand again doesn't get rid of it, pressing Cmd+W doesn't get rid of it, Esc doesn't get rid of it, double-clicking the separator bar doesn't get rid of it, putting in an actual key and then looking for buttons, there's still no way to get rid of it.

The best I can do is drag it across to like 10px wide - it has a minimum size. Is there a way to close it?

If applicable, add mockups / screenshots to help present your vision of the feature

No response

adamsoutar avatar Sep 16 '23 19:09 adamsoutar

Hey @adamsoutar, what you're looking for is the button used to close the associated dock that is housing the assistant. It looks like a Z.

SCR-20230917-ttad

JosephTLyons avatar Sep 18 '23 02:09 JosephTLyons

Cheers mate.

I know it probably seems like a silly little ticket, but given the fact that someone filed a dupe, and somebody else gave this issue a thumbs-up, it might be worth the dev team looking into more intuitive UX? :)

I personally wouldn't expect [Z] to mean "Toggle Right Dock", nor would I expect to look in the Status Bar to close something that looks like a tab and came from a button in the top right.

And to me it seems like Cmd+W should work on these panels because it doesn't conflict with anything atm - it just does nothing.

adamsoutar avatar Sep 18 '23 13:09 adamsoutar

Something to note is that assistant isn't tied directly to any specific dock, but whatever dock you decide to put it in (right or left in this case).

The model might be easier to understand when you think about the project panel, which works the same way. You put it in your preferred dock (right or left) and the the project panel button opens and closes that dock. Same thing happens for assistant, the terminal, and the collaboration panel, which all have buttons in the status bar that trigger their dock to open / close.

I think there are still ways we can help make things more obvious to the user, so I've tagged this as a discoverability issue.

JosephTLyons avatar Sep 18 '23 14:09 JosephTLyons

Yeah, this has to be fixed, I had to do a Google search to find a GitHub issue to close a panel. Definitely needs some UX work. 🙈

tkgalk avatar Oct 02 '23 12:10 tkgalk

In my case I disabled the assistant panel in the setting.json file

  "assistant": {
    "button": false
  },

So now if it opens I can't close it anymore since the icons is not visible anymore.

Screenshot:

Capture d’écran 2024-02-05 à 10 59 53

Yohannfra avatar Feb 05 '24 10:02 Yohannfra

Can't you close the assistant with the workspace: toggle right dock (by default bound to cmd+r) action?

mrnugget avatar Feb 06 '24 09:02 mrnugget

I just ran into this - I had also hidden the button couldn't close it.

I didn't know about the keyboard shortcut because the only place that is exposed as a far as I can tell is by the tooltip on the z button.

joshdales avatar Feb 14 '24 15:02 joshdales