zed icon indicating copy to clipboard operation
zed copied to clipboard

disable eslint via configuration

Open lukeed opened this issue 2 years ago • 4 comments

Check for existing issues

  • [X] Completed

Describe the feature

It's nice that ESLint support is now added, but I only want it on & running when I want to see it.

I should be able to disable ESLint via global and project-specific configuration files. I should not have to create an ESLint config file to disable Zed's internal ESLint ruleset

If applicable, add mockups / screenshots to help present your vision of the feature

No response

lukeed avatar Nov 01 '23 22:11 lukeed

Same here, would love to be able to completely disabled Zed's built-in ESLINT support until stable/finalised (too many discrepancies with my coding experience in VSCode). Thanks 👍 :)

danielweck avatar Feb 01 '24 18:02 danielweck

Also, .eslintignore doesn't seem to have any effect?

danielweck avatar Feb 02 '24 20:02 danielweck

To copy my description here: https://github.com/zed-industries/zed/discussions/7204#discussioncomment-8335245

ESLint is yet another LSP server starting for specific languages and currently is very static and not flexible. All config values it takes are mentioned in the discussions, and local file detection is either done by the corresponding LSP server or not done at all.

SomeoneToIgnore avatar Feb 02 '24 20:02 SomeoneToIgnore

Well, I've managed to completely disable ESLINT by adding this to my .eslintrc.js:

ignorePatterns: [ "*.*" ]

(I tried various syntaxes in .eslintignore, to no avail ... notably the [s]rc PathMatcher / Glob trick I reported elsewhere in this repository in order to reference root folders/files)

At this moment in time, in my codebases, Zed's ESLINT integration is completely broken as there are "red squiggles" all over my source tree (despite linting ok in Visual Studio Code as well as via the ESLINT + PRETTIER command line). I'm still enjoying Zed's speed of execution though, so I'll continue experimenting but there are currently many DX features which I find essential in VSCode.

Onwards and upwards, well done Zed dev team!! :)

danielweck avatar Feb 02 '24 21:02 danielweck

It seems to be implemented:

settings.json:

{
  "language_servers": [ "!eslint", "..."]
}

It can even be done on a per directory basis by using .zed/settings.json

jerome-benoit avatar Jul 18 '24 22:07 jerome-benoit