zed icon indicating copy to clipboard operation
zed copied to clipboard

Collab sign in not working

Open Zk2u opened this issue 2 years ago • 2 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

I'm trying to login using the top taskbar item. It doesn't do anything in the UI at all - still displays login button. Reinstalled 3x to no avail. Also removed keychain item and then it opens the GitHub site and I login online and get redirected back to my editor - and it still doesn't do anything. I'm running preview but this has been happening on both stable and preview for months.

Environment

Zed: v0.114.1 (preview) OS: macOS 14.0.0 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

2023-11-27T12:28:51 [INFO] set status on client 0: Authenticating
2023-11-27T12:28:53 [INFO] set status on client 56932: Connecting
2023-11-27T12:28:53 [INFO] connected to rpc endpoint https://collab-preview.zed.dev/rpc
2023-11-27T12:28:54 [INFO] add connection to peer
2023-11-27T12:28:54 [INFO] waiting for server hello
2023-11-27T12:28:55 [ERROR] crates/collab_ui/src/collab_titlebar_item.rs:864: no hello message received
2023-11-27T12:30:47 [ERROR] oneshot canceled
2023-11-27T12:30:47 [ERROR] oneshot canceled
2023-11-27T12:30:50 [INFO] ========== starting zed ==========
2023-11-27T12:30:50 [INFO] Opening main db
2023-11-27T12:30:51 [INFO] Opening main db
2023-11-27T12:30:51 [INFO] set status on client 0: Authenticating
2023-11-27T12:30:51 [INFO] set status on client 56932: Connecting
2023-11-27T12:30:51 [INFO] build git repository ".git"
2023-11-27T12:30:51 [INFO] set environment variables from shell:/bin/zsh, path:/opt/homebrew/opt/binutils/bin:/opt/homebrew/opt/llvm/bin:/Users/asteria/google-cloud-sdk/bin:/opt/homebrew/opt/openssl@3/bin:/Users/asteria/.bun/bin:/Users/asteria/Library/pnpm:/Users/asteria/.volta/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/local/bin:/opt/local/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/usr/local/MacGPG2/bin:/Applications/VMware Fusion Tech Preview.app/Contents/Public:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/asteria/.cargo/bin:/Users/asteria/.fig/bin:/Users/asteria/.local/bin:/Users/asteria/Library/Application Support/JetBrains/Toolbox/scripts:/Users/asteria/.orbstack/bin:/Users/asteria/go/bin:/Users/asteria/.cargo/bin:/opt/homebrew/opt/fzf/bin
2023-11-27T12:30:51 [INFO] Opening main db
2023-11-27T12:30:51 [INFO] Opening main db
2023-11-27T12:30:51 [INFO] starting language server "rust-analyzer", path: "/Users/asteria/Developer/concilia", id: 1
2023-11-27T12:30:51 [INFO] connected to rpc endpoint https://collab-preview.zed.dev/rpc
2023-11-27T12:30:51 [INFO] Node runtime install_if_needed
2023-11-27T12:30:51 [INFO] add connection to peer
2023-11-27T12:30:51 [INFO] waiting for server hello
2023-11-27T12:30:52 [INFO] 0 unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2023-11-27T12:30:52.124Z] Agent service starting",
  "metadataStr": "[DEBUG] [agent] [2023-11-27T12:30:52.124Z]",
  "extra": [
    "Agent service starting"
  ]
}
2023-11-27T12:30:52 [INFO] 0 unhandled notification client/registerCapability:
{
  "registrations": [
    {
      "id": "8bb7d66d-90c0-4930-a4bb-b0fbbbc2e096",
      "method": "workspace/didChangeWorkspaceFolders",
      "registerOptions": {}
    }
  ]
}
2023-11-27T12:30:52 [INFO] 0 unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2023-11-27T12:30:52.567Z] Telemetry initialized",
  "metadataStr": "[DEBUG] [agent] [2023-11-27T12:30:52.567Z]",
  "extra": [
    "Telemetry initialized"
  ]
}
2023-11-27T12:30:52 [INFO] 1 unhandled notification experimental/serverStatus:
{
  "health": "ok",
  "quiescent": false,
  "message": null
}
2023-11-27T12:30:52 [ERROR] crates/zed/src/main.rs:313: no hello message received
2023-11-27T12:30:53 [WARN] Generic lsp request to rust-analyzer failed: content modified
2023-11-27T12:30:53 [ERROR] inlay hint update task for range Anchor { timestamp: Lamport {0: 0}, offset: 0, bias: Left, buffer_id: None }..Anchor { timestamp: Lamport {0: 1}, offset: 530, bias: Right, buffer_id: Some(3) } failed: inlay hint fetch task: inlay hints LSP request: content modified
2023-11-27T12:30:53 [WARN] Generic lsp request to rust-analyzer failed: content modified
2023-11-27T12:30:53 [ERROR] inlay hint update task for range Anchor { timestamp: Lamport {0: 0}, offset: 0, bias: Left, buffer_id: None }..Anchor { timestamp: Lamport {0: 1}, offset: 530, bias: Right, buffer_id: Some(3) } failed: inlay hint fetch task: inlay hints LSP request: content modified
2023-11-27T12:30:56 [INFO] 1 unhandled notification experimental/serverStatus:
{
  "health": "ok",
  "quiescent": true,
  "message": null
}

Zk2u avatar Nov 27 '23 12:11 Zk2u

This is still happening with the latest version with a more useful error message now. I'm connected to the internet. Screenshot 2024-02-28 at 09 48 20 Screenshot 2024-02-28 at 09 48 24

Zk2u avatar Feb 28 '24 09:02 Zk2u

I've tried deleting the keychain entry and managed to login to a throwaway GitHub account and that worked. I guess Zed doesn't like this account in particular :(

Zk2u avatar Mar 05 '24 10:03 Zk2u

This happens to me to. Exactly the same as above.

I deleted the keychain and then tried logging in again, but the "Sign in" button still appears. Copilot however still works.

hhofner avatar Mar 14 '24 06:03 hhofner

cc @ConradIrwin - any idea what might be going on here? Wonder if there's some issue with the user records here.

JosephTLyons avatar Mar 15 '24 04:03 JosephTLyons

@hhofner Thanks for the report, and sorry about this! It looks you (and one other user, unfortunately not @617a7aa - but if you have a different GitHub handle let me know if it magically works now) were missed in a migration I ran a while back.

This should now be resolved for you, and I'll add a non-null constraint to the database to avoid this recurring.

ConradIrwin avatar Mar 15 '24 18:03 ConradIrwin

Thank you very much. I've somehow lost the ability to change my username back annoyingly but I'll try it later to verify it works with the two a's.

Zk2u avatar Mar 15 '24 18:03 Zk2u

@617a7aa I believe your issue should also now be fixed (it was remarkably similar to @hhofner's, but on a different database table).

Sorry for the delay in getting back to you here!

ConradIrwin avatar Mar 15 '24 18:03 ConradIrwin