zed icon indicating copy to clipboard operation
zed copied to clipboard

google_ai: Parse thought parts in Gemini responses

Open dogonthehorizon opened this issue 6 months ago • 4 comments

Closes #31902. Though I'm not sure how completely. I noticed that function parts are being ignored so I did the same. Not sure if this impacts the ability to show thinking in the agent window, as I'm rather unfamiliar with what's happening behind the scenes. This small fix enables me to use Gemini 2.5 Pro Preview again.

Release Notes:

  • Fixed thought parsing issue with Google Gemini 2.5 Pro Preview

dogonthehorizon avatar Jun 02 '25 19:06 dogonthehorizon

We require contributors to sign our Contributor License Agreement, and we don't have @dogonthehorizon on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Jun 02 '25 19:06 cla-bot[bot]

@cla-bot check

dogonthehorizon avatar Jun 02 '25 19:06 dogonthehorizon

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jun 02 '25 19:06 cla-bot[bot]

I think this should be merged since this is a strict improvement on the current state.

However, that would still not allow zed to re-use a previous chain of thought during a subsequent question in the same thread.

lovasoa avatar Jun 02 '25 20:06 lovasoa

@dogonthehorizon, thanks for the fix!

osyvokon avatar Jun 03 '25 10:06 osyvokon