zed icon indicating copy to clipboard operation
zed copied to clipboard

vim: Add vim counts and vim shortcuts to project_panel

Open AidanV opened this issue 6 months ago • 1 comments

Closes #10930 Closes #11353

Release Notes:

  • Adds commands to project_panel
    • ctrl-u scrolls the project_panel up half of the visible entries
    • ctrl-d scrolls the project_panel down half of the visible entries
    • z z scrolls current selection to center of window
    • z t scrolls current selection to top of window
    • z b scrolls current selection to bottom of window
    • {num} j and {num} k now move up and down with a count

AidanV avatar May 27 '25 22:05 AidanV

Nice, thanks for this!

We should be able to re-use the existing vim::Number actions for this instead of adding a new one. Though, we might need to move the registration of them to the workspace instead of the editor.

I'm also not sure what the difference is between scroll_item_onscreen and scroll_to_item. Do we need to add a new behavior (and if so, can we leave the old one as is?).

ConradIrwin avatar Jun 03 '25 14:06 ConradIrwin

@ConradIrwin could you help me get the test_folded_multibuffer_excerpts test case to pass. I think it is because it is not initializing a workspace and since numbers were moved to be registered in the workspace it is no longer working.

AidanV avatar Jun 30 '25 02:06 AidanV

Can't wait for this to be GA! 🎉

DarrylBrooks97 avatar Jul 30 '25 18:07 DarrylBrooks97

Closing this for now due to conflicts, though it is something I do want to figure out how to do.

It seems like the crux of the issue is handling the counts, as they are already stored globally, maybe we can just leave the editor actions in addition to the workspace ones?

ConradIrwin avatar Aug 15 '25 02:08 ConradIrwin