zed icon indicating copy to clipboard operation
zed copied to clipboard

Display the first keystroke instead of an error for multi-keystroke binding

Open sygi opened this issue 9 months ago • 5 comments

Ideally we would show multi-keystroke binding, but I'd say this improves over the status quo.

A partial solution to #27334

Release Notes:

  • Fixed spurious warning for lack of edit prediction on multi-keystroke binding

sygi avatar May 26 '25 19:05 sygi

We require contributors to sign our Contributor License Agreement, and we don't have @sygi on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar May 26 '25 19:05 cla-bot[bot]

@cla-bot check

sygi avatar May 26 '25 19:05 sygi

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar May 26 '25 19:05 cla-bot[bot]

Thanks for doing this. I think this is a good start. Would it be possible / are you interested in making it so multi-keystroke bindings are displayed in this PR? I think that would be a more complete fix, even if I agree the current state of the PR is better than the status quo.

Happy to help if you're interested!

probably-neb avatar Jun 03 '25 07:06 probably-neb

Thanks for the offer. I would be keen to try to make it work but given it may take a while for both writing and review I think it's best to push this through as a simple change and then hope we'll get to something properly working sometime in the future

sygi avatar Jun 03 '25 13:06 sygi

Sounds good, if you wouldn't mind resolving the conflicts we can get this merged pretty soon here.

probably-neb avatar Jun 06 '25 07:06 probably-neb