zed
zed copied to clipboard
zed-industries
ci: Check for broken links
This PR fixes some broken links that where found using lychee as discussed today with @JosephTLyons and @nathansobo at the RustNL hackathon. Using lychee-action we can scan for broken links daily to prevent issues in the future. There are still 6 broken links that I didn't know how to fix myself. See https://github.com/thomas-zahner/zed/actions/runs/15075808232 for details.
Missing images
Errors in ./docs/src/channels.md
[ERROR] file:///home/runner/work/zed/zed/docs/.gitbook/assets/channels-3.png | Cannot find file
[ERROR] file:///home/runner/work/zed/zed/docs/.gitbook/assets/channels-1.png | Cannot find file
[ERROR] file:///home/runner/work/zed/zed/docs/.gitbook/assets/channels-2.png | Cannot find file
These errors are showing up as missing images on https://zed.dev/docs/channels I tried to search the git history to see when or why they were deleted but didn't find anything.
./crates/assistant_tools/src/edit_agent/evals/fixtures/zode/prompt.md
There are three errors in that file. I don't fully understand how these issues were caused historically. Technically it would be possible to ignore the files but of course if possible we should address the issues.
Release Notes:
- N/A
Hi @thomas-zahner! We require contributors to sign the Zed Contributor license agreement. Could you please sign the Zed CLA? Since clabot has been acting up, please comment here so we can manually verify. Thanks.
@notpeter Ah I didn't realise this was necessary. I accepted it just now.
Hey @thomas-zahner, I'm going to get this over the finish line by integrating with my recent addition of a docs validation step in CI. Thanks for getting this all setup!
Note, this test gives a false positive when committing documentation that links to new source files in the same commit. Example run failure.
Basically I added script/freebsd to the repo and then added documentation which links to that file. This is likely are a rare situation and much less common that committing bad links with typos. :P
Anyways, thanks for implementing this @thomas-zahner!
P.S. That build failure did not stop auto-merge. @probably-neb Let's pair on a fix on Monday.
Fix for not requiring check_docs to pass as pre-req for automerge here:
- https://github.com/zed-industries/zed/pull/32470
Hey @thomas-zahner, I'm going to get this over the finish line by integrating with my recent addition of a docs validation step in CI. Thanks for getting this all setup!
@probably-neb @notpeter Sure, I'm glad I could help :+1: Thank you for polishing and merging it.