zed icon indicating copy to clipboard operation
zed copied to clipboard

Reapply "ui: Account for padding of parent container during scrollbar layout"

Open MrSubidubi opened this issue 7 months ago • 0 comments

This PR reapplies #27402 which was reverted in https://github.com/zed-industries/zed/pull/30544 due to the issue @ConradIrwin reported in https://github.com/zed-industries/zed/pull/27402#issuecomment-2871745132. The reported issue is already present on main but not visible, see https://github.com/zed-industries/zed/pull/27402#issuecomment-2872546903 for more context and reproduction steps.

The fix here was to move the padding for the hover popover up to the parent container. This does not fix the underlying problem but serves as workaround without any disadvantages until a better solution is found. I would currently guess that the underlying issue might be related to some rem-size calculations for small font sizes or something similar (e.g. https://github.com/zed-industries/zed/pull/22732 could possibly be somewhat related).

Notably, the fix here does not cause any difference in layouting (the following screenshots are actually distinct images), yet fixes the problem at hand.

Default font size (15px)

main This PR
main_large PR

Smaller font size (12px)

main This PR
pr_large PR

Furthermore, for the second scenario, the popover would be scrollable on main. As there is no scrollbar in the second image for this PR, this no longer happens with this branch.

Release Notes:

  • N/A

MrSubidubi avatar May 12 '25 14:05 MrSubidubi