zed icon indicating copy to clipboard operation
zed copied to clipboard

Add kernel detection for language support of runnable markdown cells

Open JonGretar opened this issue 8 months ago • 5 comments

Closes #27757

Release Notes:

  • List of runnable markdown cells is now based on detected jupyter kernels instead of hardcoded to Python and TypeScript

JonGretar avatar Apr 30 '25 11:04 JonGretar

This would be my first real Rust code. Possibly it is lacking in quality. But it seems to work.

JonGretar avatar Apr 30 '25 11:04 JonGretar

Oooh, thank you. You'll need to address the clippy lints shown in the failing checks below.

rgbkrk avatar May 07 '25 15:05 rgbkrk

Oooh, thank you. You'll need to address the clippy lints shown in the failing checks below.

Thanks @rgbkrk

Yeah I'm hitting a roadblock with the test_markdown_code_blocks test. Don't quite have the Rust skills.

I struggle with the modifying the tests as I need to either add kernels to the jupyter core programatically or mock the jupyter core somehow. And it seems tricky and not figuring it out.

JonGretar avatar May 08 '25 11:05 JonGretar

Got the tests running. Thanks to generous help from Zed's new Agent mode. 😆 Don't know if the solution is to everyones liking. But it runs.

JonGretar avatar May 10 '25 18:05 JonGretar

This is now ok I think.

Just for future reference. How do I run the syntax check locally? Or is there a single command to run all the same tests?

JonGretar avatar May 12 '25 13:05 JonGretar

Thanks @JonGretar!

rgbkrk avatar May 22 '25 03:05 rgbkrk

How do I run the syntax check locally?

Should be cargo xtask clippy

rgbkrk avatar May 22 '25 03:05 rgbkrk