zed icon indicating copy to clipboard operation
zed copied to clipboard

One Dark Theme: The highlighted text within comment blocks in the search results is not readable.

Open dumindu opened this issue 11 months ago • 1 comments

Summary

One Dark Theme: The highlighted text within comment blocks in the search results is not readable.

Description

One Dark Theme: The highlighted text within comment blocks in the search results is not readable.

Image

Steps to reproduce:

  1. Use builtin One Dark theme
  2. Go to setting and search "zed"

Expected Behavior: The highlighted text within comment blocks in the search results should be readable. Actual Behavior: The highlighted text within comment blocks in the search results is not readable.

Zed Version and System Specs

Zed 0.181.7 , macOS Sequoia 15.4

dumindu avatar Apr 15 '25 16:04 dumindu

I can reproduce this issue. We should either update the comment color or query the highlight so that both colors are in contrast with each other. Thanks for reporting this.

smitbarmase avatar May 20 '25 15:05 smitbarmase

same, its seems minor but its so difficult to see the results of ctrl+f etc which I call constantly. here is a screenshot of highlighting the word "background".

The actual selection is barely visible relative to the other instances which are automatically highlighted

Image

evan-forbes avatar Jun 19 '25 19:06 evan-forbes

@iamnbutler Looks like not a complete fix/ one small case to fix. @smitbarmase keep up the good work.

Image

Steps to reproduce:

  • Use builtin One Dark theme
  • Go to setting and search "zed"
  • Check anywhere inside the file/ editor.

dumindu avatar Aug 30 '25 14:08 dumindu

It's not released yet, just merged into main. You'll need to wait until Wednesday for it to be in Preview.

Image

smitbarmase avatar Aug 30 '25 14:08 smitbarmase

Can't wait! Nice work 👏

dumindu avatar Aug 30 '25 14:08 dumindu