zed-industries
Adjust pane magnification and handle conditions in layout
I wasn’t sure about the purpose of the if active_pane_magnification.is_none() check, as I didn’t notice any side effects after removing it. However, the issue was resolved without it.
Closes #4265
Release Notes:
-Fixed
- Pane shrinking issue is fixed by calculating the remaining area in the pane group instead of attempting “1” to it.
- Pane separation issue is fixed.
@mikayla-maki
I now better understand the intended behavior and have updated the code to properly handle both cases:
-
When active_pane_magnification is Some:
- Only dividers are visible (no handles)
- Users cannot manually resize panes
- This prevents conflict with the magnification feature
-
When active_pane_magnification is None:
- Both dividers and handles are visible
- Users can manually resize panes using the handles
Please let me know if this aligns better with the intended behavior. Thank you!
Hey @tugkanpilka, taking a look at this, It looks like what you've done helped, but I don't think we should close the linked issue, as there are still many unresolved visual discrepancies when the magnification setting is enabled. I think I understand what you've done so far, and I'm happy to merge this as is and not close the issue, however, if you'd like to keep working and fix the other rendering problems in order to completely close the issue I'd obviously appreciate it!
I also recommend merging or rebasing on top of main before we merge this! There's been quite a few changes since this branch was last updated
Very tall screenshot showing multiple rendering issues
Closing, as we removed support for pane magnification, in part due to the scope and complexity of issues this feature caused like the ones this PR was attempting to solve. Sorry this means your work is going to waste, however, the feature as a whole was just incomplete and did not meet the quality bar we set for features in Zed. I hope you understand.