zed icon indicating copy to clipboard operation
zed copied to clipboard

extension: Download extension should check source download integrity

Open CharlesChen0823 opened this issue 1 year ago • 4 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

I often face this error

Failed to start language server "rust-analyzer": failed to spawn command. path: "C:\\Users\\$user$\\AppData\\Local\\Zed\\languages\\rust-analyzer\\rust-analyzer-2024-12-09\\rust-analyzer.exe", working directory: "C:\\$user\\programming\\rust\\zed", args: []
2024-12-09T21:55:05.995711+08:00 [ERROR] server stderr: ""

after checking, i found the download rust-analyzer.exe is not integrity, I think before extract zip file ,we should check download integrity.

I want add

#[derive(Deserialize, Debug)]
pub struct GithubReleaseAsset {
    pub name: String,
    pub browser_download_url: String,
+    pub size: usize,
}

for checking, but need update all extension.....

Environment

Zed: v0.166.0 (Zed Dev ac07b9197a5a2814dad605148fe032f6777ce5fe) OS: Windows 10.0.22631 Memory: 63.2 GiB Architecture: x86_64 GPU: AMD Radeon(TM) Graphics || AMD proprietary driver || 24.10.1 (AMD proprietary shader compiler)

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

CharlesChen0823 avatar Dec 09 '24 14:12 CharlesChen0823

Checking the size is not enough, you'd want a SHA-256.

tv42 avatar Dec 27 '24 20:12 tv42

I think this is a duplicate of #13918

tv42 avatar Dec 27 '24 20:12 tv42

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

github-actions[bot] avatar Apr 30 '25 07:04 github-actions[bot]

still need

CharlesChen0823 avatar Apr 30 '25 07:04 CharlesChen0823

We now check a sha256 digest for GitHub released binaries where applicable, currently rust-analyzer and clangd.

Veykril avatar Aug 08 '25 17:08 Veykril